discourse/spec/lib/file_helper_spec.rb

165 lines
4.3 KiB
Ruby
Raw Normal View History

# frozen_string_literal: true
require "file_helper"
2017-05-15 15:56:29 -05:00
RSpec.describe FileHelper do
2017-05-15 15:56:29 -05:00
let(:url) { "https://eviltrout.com/trout.png" }
let(:png) { File.read("#{Rails.root}/spec/fixtures/images/cropped.png") }
2017-05-15 15:56:29 -05:00
before do
stub_request(:any, %r{https://eviltrout.com})
2017-05-15 15:56:29 -05:00
stub_request(:get, url).to_return(body: png)
end
describe "download" do
it "correctly raises an OpenURI HTTP error if it gets a 404 even with redirect" do
url = "http://fourohfour.com/404"
stub_request(:get, url).to_return(status: 404, body: "404")
expect do
begin
FileHelper.download(
url,
max_file_size: 10_000,
tmp_file_name: "trouttmp",
follow_redirect: true,
)
rescue => e
expect(e.io.status[0]).to eq("404")
raise
end
end.to raise_error(OpenURI::HTTPError, "404 Error")
end
it "does not follow redirects if instructed not to" do
url2 = "https://test.com/image.png"
stub_request(:get, url).to_return(status: 302, body: "", headers: { location: url2 })
missing =
FileHelper.download(
url,
max_file_size: 10_000,
tmp_file_name: "trouttmp",
follow_redirect: false,
)
expect(missing).to eq(nil)
end
it "does follow redirects if instructed to" do
url2 = "https://test.com/image.png"
stub_request(:get, url).to_return(status: 302, body: "", headers: { location: url2 })
stub_request(:get, url2).to_return(status: 200, body: "i am the body")
begin
found =
FileHelper.download(
url,
max_file_size: 10_000,
tmp_file_name: "trouttmp",
follow_redirect: true,
)
expect(found.read).to eq("i am the body")
ensure
found&.close
found&.unlink
end
end
it "correctly raises an OpenURI HTTP error if it gets a 404" do
url = "http://fourohfour.com/404"
stub_request(:get, url).to_return(status: 404, body: "404")
expect do
begin
FileHelper.download(
url,
max_file_size: 10_000,
tmp_file_name: "trouttmp",
follow_redirect: false,
)
rescue => e
expect(e.io.status[0]).to eq("404")
raise
end
end.to raise_error(OpenURI::HTTPError)
end
2017-05-15 15:56:29 -05:00
it "returns a file with the image" do
2018-08-17 04:34:25 -05:00
begin
tmpfile = FileHelper.download(url, max_file_size: 10_000, tmp_file_name: "trouttmp")
2018-08-17 04:34:25 -05:00
expect(Base64.encode64(tmpfile.read)).to eq(Base64.encode64(png))
ensure
tmpfile&.close
tmpfile&.unlink
2018-08-17 04:34:25 -05:00
end
2017-05-15 15:56:29 -05:00
end
it "works with a protocol relative url" do
2018-08-17 04:34:25 -05:00
begin
tmpfile =
FileHelper.download(
"//eviltrout.com/trout.png",
max_file_size: 10_000,
tmp_file_name: "trouttmp",
)
2018-08-17 04:34:25 -05:00
expect(Base64.encode64(tmpfile.read)).to eq(Base64.encode64(png))
ensure
tmpfile&.close
tmpfile&.unlink
2018-08-17 04:34:25 -05:00
end
2017-05-15 15:56:29 -05:00
end
describe "when max_file_size is exceeded" do
it "should return nil" do
tmpfile =
FileHelper.download(
"//eviltrout.com/trout.png",
max_file_size: 1,
tmp_file_name: "trouttmp",
)
expect(tmpfile).to eq(nil)
end
2018-08-17 03:52:55 -05:00
it "is able to retain the tmpfile" do
2018-08-17 04:34:25 -05:00
begin
tmpfile =
FileHelper.download(
"//eviltrout.com/trout.png",
max_file_size: 1,
tmp_file_name: "trouttmp",
retain_on_max_file_size_exceeded: true,
)
2018-08-17 03:52:55 -05:00
2018-08-17 04:34:25 -05:00
expect(tmpfile.closed?).to eq(false)
ensure
tmpfile&.close
tmpfile&.unlink
2018-08-17 04:34:25 -05:00
end
2018-08-17 03:52:55 -05:00
end
end
describe "when url is a jpeg" do
let(:url) { "https://eviltrout.com/trout.jpg" }
it "should prioritize the content type returned by the response" do
2018-08-17 04:34:25 -05:00
begin
stub_request(:get, url).to_return(body: png, headers: { "content-type": "image/png" })
tmpfile = FileHelper.download(url, max_file_size: 10_000, tmp_file_name: "trouttmp")
expect(File.extname(tmpfile)).to eq(".png")
2018-08-17 04:34:25 -05:00
ensure
tmpfile&.close
tmpfile&.unlink
2018-08-17 04:34:25 -05:00
end
end
end
2017-05-15 15:56:29 -05:00
end
end