2019-05-02 17:17:27 -05:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
2014-04-11 00:43:33 -05:00
|
|
|
# Cross-process locking using Redis.
|
2019-08-14 03:56:43 -05:00
|
|
|
# Expiration happens when the current time is greater than the expire time
|
2014-04-11 00:43:33 -05:00
|
|
|
class DistributedMutex
|
2022-07-11 07:16:37 -05:00
|
|
|
DEFAULT_VALIDITY = 60
|
2022-08-12 12:39:01 -05:00
|
|
|
CHECK_READONLY_ATTEMPTS = 5
|
2022-07-11 07:16:37 -05:00
|
|
|
|
|
|
|
LOCK_SCRIPT = DiscourseRedis::EvalHelper.new <<~LUA
|
|
|
|
local now = redis.call("time")[1]
|
|
|
|
local expire_time = now + ARGV[1]
|
|
|
|
local current_expire_time = redis.call("get", KEYS[1])
|
|
|
|
|
|
|
|
if current_expire_time and tonumber(now) <= tonumber(current_expire_time) then
|
|
|
|
return nil
|
|
|
|
else
|
|
|
|
local result = redis.call("setex", KEYS[1], ARGV[1] + 1, tostring(expire_time))
|
|
|
|
return expire_time
|
|
|
|
end
|
|
|
|
LUA
|
|
|
|
|
|
|
|
UNLOCK_SCRIPT = DiscourseRedis::EvalHelper.new <<~LUA
|
|
|
|
local current_expire_time = redis.call("get", KEYS[1])
|
|
|
|
|
|
|
|
if current_expire_time == ARGV[1] then
|
|
|
|
local result = redis.call("del", KEYS[1])
|
|
|
|
return result ~= nil
|
|
|
|
else
|
|
|
|
return false
|
|
|
|
end
|
|
|
|
LUA
|
2014-04-11 00:43:33 -05:00
|
|
|
|
2023-01-25 14:19:11 -06:00
|
|
|
def self.synchronize(
|
|
|
|
key,
|
|
|
|
redis: nil,
|
|
|
|
validity: DEFAULT_VALIDITY,
|
|
|
|
max_get_lock_attempts: nil,
|
|
|
|
&blk
|
|
|
|
)
|
|
|
|
self.new(
|
|
|
|
key,
|
|
|
|
redis: redis,
|
|
|
|
validity: validity,
|
|
|
|
max_get_lock_attempts: max_get_lock_attempts,
|
|
|
|
).synchronize(&blk)
|
2014-07-29 23:04:27 -05:00
|
|
|
end
|
|
|
|
|
2023-01-25 14:19:11 -06:00
|
|
|
def initialize(key, redis: nil, validity: DEFAULT_VALIDITY, max_get_lock_attempts: nil)
|
2014-04-11 00:43:33 -05:00
|
|
|
@key = key
|
2018-09-19 00:49:18 -05:00
|
|
|
@using_global_redis = true if !redis
|
2019-12-03 03:05:53 -06:00
|
|
|
@redis = redis || Discourse.redis
|
2014-04-13 19:51:46 -05:00
|
|
|
@mutex = Mutex.new
|
2019-02-19 19:28:10 -06:00
|
|
|
@validity = validity
|
2023-01-25 14:19:11 -06:00
|
|
|
@max_get_lock_attempts = max_get_lock_attempts
|
2014-04-11 00:43:33 -05:00
|
|
|
end
|
|
|
|
|
2014-04-13 19:51:46 -05:00
|
|
|
# NOTE wrapped in mutex to maintain its semantics
|
2019-02-19 19:28:10 -06:00
|
|
|
def synchronize
|
2022-07-11 07:16:37 -05:00
|
|
|
result = nil
|
|
|
|
|
2019-08-01 03:12:05 -05:00
|
|
|
@mutex.synchronize do
|
|
|
|
expire_time = get_lock
|
|
|
|
|
|
|
|
begin
|
2022-07-11 07:16:37 -05:00
|
|
|
result = yield
|
2019-08-01 03:12:05 -05:00
|
|
|
ensure
|
|
|
|
current_time = redis.time[0]
|
2019-08-04 20:57:35 -05:00
|
|
|
if current_time > expire_time
|
2023-01-09 06:10:19 -06:00
|
|
|
warn(
|
|
|
|
"held for too long, expected max: #{@validity} secs, took an extra #{current_time - expire_time} secs",
|
|
|
|
)
|
2019-08-01 03:12:05 -05:00
|
|
|
end
|
|
|
|
|
2022-07-11 07:16:37 -05:00
|
|
|
unlocked = UNLOCK_SCRIPT.eval(redis, [prefixed_key], [expire_time.to_s])
|
|
|
|
if !unlocked && current_time <= expire_time
|
2019-08-14 03:56:43 -05:00
|
|
|
warn("the redis key appears to have been tampered with before expiration")
|
2019-08-01 03:12:05 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
end
|
2022-07-11 07:16:37 -05:00
|
|
|
|
|
|
|
result
|
2019-08-01 03:12:05 -05:00
|
|
|
end
|
|
|
|
|
2023-01-25 14:19:11 -06:00
|
|
|
class MaximumAttemptsExceeded < StandardError
|
|
|
|
end
|
|
|
|
|
2019-08-01 03:12:05 -05:00
|
|
|
private
|
|
|
|
|
|
|
|
attr_reader :key
|
|
|
|
attr_reader :redis
|
|
|
|
attr_reader :validity
|
2023-01-25 14:19:11 -06:00
|
|
|
attr_reader :max_get_lock_attempts
|
2019-08-01 03:12:05 -05:00
|
|
|
|
|
|
|
def get_lock
|
2018-09-19 00:49:18 -05:00
|
|
|
attempts = 0
|
|
|
|
|
2019-08-01 03:12:05 -05:00
|
|
|
while true
|
2022-07-11 07:16:37 -05:00
|
|
|
expire_time = LOCK_SCRIPT.eval(redis, [prefixed_key], [validity])
|
|
|
|
|
|
|
|
return expire_time if expire_time
|
2019-08-01 03:12:05 -05:00
|
|
|
|
2022-08-12 12:39:01 -05:00
|
|
|
# Exponential backoff, max duration 1s
|
|
|
|
interval = attempts < 10 ? (0.001 * 2**attempts) : 1
|
|
|
|
sleep interval
|
2022-12-13 16:09:01 -06:00
|
|
|
attempts += 1
|
2022-07-11 07:16:37 -05:00
|
|
|
|
2018-09-19 00:49:18 -05:00
|
|
|
# in readonly we will never be able to get a lock
|
2022-12-13 16:09:01 -06:00
|
|
|
if @using_global_redis && Discourse.recently_readonly? && attempts > CHECK_READONLY_ATTEMPTS
|
|
|
|
raise Discourse::ReadOnly
|
2018-09-19 00:49:18 -05:00
|
|
|
end
|
2023-01-25 14:19:11 -06:00
|
|
|
|
|
|
|
if max_get_lock_attempts && attempts > max_get_lock_attempts
|
|
|
|
raise DistributedMutex::MaximumAttemptsExceeded
|
|
|
|
end
|
2014-04-13 19:51:46 -05:00
|
|
|
end
|
|
|
|
end
|
|
|
|
|
2022-07-11 07:16:37 -05:00
|
|
|
def prefixed_key
|
|
|
|
@prefixed_key ||= redis.respond_to?(:namespace_key) ? redis.namespace_key(key) : key
|
2014-04-11 00:43:33 -05:00
|
|
|
end
|
|
|
|
|
2022-07-11 07:16:37 -05:00
|
|
|
def warn(msg)
|
|
|
|
Rails.logger.warn("DistributedMutex(#{key.inspect}): #{msg}")
|
2019-08-01 03:12:05 -05:00
|
|
|
end
|
2014-04-11 00:43:33 -05:00
|
|
|
end
|