discourse/Dangerfile

20 lines
1.3 KiB
Plaintext
Raw Normal View History

if github.pr_json && (github.pr_json["additions"] || 0) > 250 || (github.pr_json["deletions"] || 0) > 250
2018-07-25 13:36:09 -05:00
warn("This pull request is big! We prefer smaller PRs whenever possible, as they are easier to review. Can this be split into a few smaller PRs?")
2018-07-24 09:12:15 -05:00
end
prettier_offenses = `yarn --silent prettier --list-different "app/assets/stylesheets/**/*.scss" "app/assets/javascripts/**/*.es6" "test/javascripts/**/*.es6"`.split("\n")
unless prettier_offenses.empty?
2018-07-24 09:12:15 -05:00
fail(%{
2018-07-26 14:45:01 -05:00
This PR doesn't match our required code formatting standards, as enforced by prettier.io. <a href='https://meta.discourse.org/t/prettier-code-formatting-tool/93212'>Here's how to set up prettier in your code editor.</a>\n
2018-07-26 10:03:36 -05:00
#{prettier_offenses.map { |o| github.html_link(o) }.join("\n")}
2018-07-24 09:12:15 -05:00
})
end
has_locales_changes = !git.modified_files.grep(/config\/locales/).empty?
has_en_locales_changes = git.modified_files.include?("config/locales/client.en.yml") || git.modified_files.include?("config/locales/server.en.yml")
if has_locales_changes && !has_en_locales_changes
fail("Please submit your non-English translation updates via [Transifex](https://www.transifex.com/discourse/discourse-org/). You can read more on how to contribute translations [here](https://meta.discourse.org/t/contribute-a-translation-to-discourse/14882).")
end