mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Use message-bus chunked encoding in development (#19878)
This was previously disabled because of incompatibility with the ember-cli proxy. This commit fixes that incompatibility, and restores the development behaviour to match production. There were three issues at play: 1. Our bootstrap-js addon handles the forwarding of most requests in the ember-cli proxy. This is not built to handle streaming responses. Solution: skip our custom request processing for `/message-bus/*` and use ember-cli's default `http-proxy`. 2. The request/response size-limiting middleware (`rawMiddleware`) would apply even to unhandled paths, causing request and response bodies to be buffered. Solution: skip it for any paths which are not handled by our custom addon. 3. Expressjs servers will buffer/compress responses. Solution: add `Cache-Control: no-transform` to message-bus responses. For now I've done this in development only, but it may be useful to add it to message-bus's default headers in future
This commit is contained in:
@@ -62,6 +62,11 @@ def setup_message_bus_env(env)
|
||||
|
||||
extra_headers["Discourse-Logged-Out"] = "1" if env[Auth::DefaultCurrentUserProvider::BAD_TOKEN]
|
||||
|
||||
if Rails.env.development?
|
||||
# Adding no-transform prevents the expressjs ember-cli proxy buffering/compressing the response
|
||||
extra_headers["Cache-Control"] = "no-transform, must-revalidate, private, max-age=0"
|
||||
end
|
||||
|
||||
hash = {
|
||||
extra_headers: extra_headers,
|
||||
user_id: user_id,
|
||||
@@ -100,6 +105,8 @@ MessageBus.on_middleware_error do |env, e|
|
||||
[403, {}, ["Invalid Access"]]
|
||||
elsif RateLimiter::LimitExceeded === e
|
||||
[429, { "Retry-After" => e.available_in.to_s }, [e.description]]
|
||||
elsif Errno::EPIPE === e
|
||||
[422, {}, ["Closed by Client"]]
|
||||
end
|
||||
end
|
||||
|
||||
|
||||
Reference in New Issue
Block a user