From 04b003500971544453e67a7f9a4c97cc59801677 Mon Sep 17 00:00:00 2001 From: Gerhard Schlager Date: Wed, 9 Nov 2022 13:53:47 +0100 Subject: [PATCH] DEV: Remove unused code and translations The edit PM button was removed in ecc8e559ecd615542f766d74ded50a6cdbc320eb --- .../app/components/topic-footer-buttons.js | 4 +--- .../tests/acceptance/personal-message-test.js | 15 +-------------- config/locales/client.en.yml | 3 --- 3 files changed, 2 insertions(+), 20 deletions(-) diff --git a/app/assets/javascripts/discourse/app/components/topic-footer-buttons.js b/app/assets/javascripts/discourse/app/components/topic-footer-buttons.js index 1d5ff71b600..e65a85aeb8e 100644 --- a/app/assets/javascripts/discourse/app/components/topic-footer-buttons.js +++ b/app/assets/javascripts/discourse/app/components/topic-footer-buttons.js @@ -1,4 +1,4 @@ -import { alias, and, or } from "@ember/object/computed"; +import { alias, or } from "@ember/object/computed"; import { computed } from "@ember/object"; import Component from "@ember/component"; import discourseComputed from "discourse-common/utils/decorators"; @@ -54,8 +54,6 @@ export default Component.extend({ inviteDisabled: or("topic.archived", "topic.closed", "topic.deleted"), - showEditOnFooter: and("topic.isPrivateMessage", "site.can_tag_pms"), - @discourseComputed("topic.message_archived") archiveIcon: (archived) => (archived ? "envelope" : "folder"), diff --git a/app/assets/javascripts/discourse/tests/acceptance/personal-message-test.js b/app/assets/javascripts/discourse/tests/acceptance/personal-message-test.js index c75513b7863..82867e72209 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/personal-message-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/personal-message-test.js @@ -1,8 +1,4 @@ -import { - acceptance, - exists, - query, -} from "discourse/tests/helpers/qunit-helpers"; +import { acceptance, query } from "discourse/tests/helpers/qunit-helpers"; import I18n from "I18n"; import { test } from "qunit"; import { visit } from "@ember/test-helpers"; @@ -10,15 +6,6 @@ import { visit } from "@ember/test-helpers"; acceptance("Personal Message", function (needs) { needs.user(); - test("footer edit button", async function (assert) { - await visit("/t/pm-for-testing/12"); - - assert.ok( - !exists(".edit-message"), - "does not show edit first post button on footer by default" - ); - }); - test("suggested messages", async function (assert) { await visit("/t/pm-for-testing/12"); diff --git a/config/locales/client.en.yml b/config/locales/client.en.yml index 0cc78869985..ec82b9fb32a 100644 --- a/config/locales/client.en.yml +++ b/config/locales/client.en.yml @@ -2751,9 +2751,6 @@ en: move_to_inbox: title: "Move to Inbox" help: "Move message back to Inbox" - edit_message: - help: "Edit first post of the message" - title: "Edit" defer: help: "Mark as unread" title: "Defer"