From 04cd3c05516beb5cd42353b62f7dee0de19a382f Mon Sep 17 00:00:00 2001 From: cpradio Date: Tue, 19 Aug 2014 20:59:20 -0400 Subject: [PATCH] Only show unique badge titles in the Badge Title dropdown Filter the preference Badge Title to only show unique badge title names. https://meta.discourse.org/t/set-title-dialog-shows-multiple-instances-of-the-same-badge/19071 --- .../discourse/controllers/preferences/badge-title.js.es6 | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/controllers/preferences/badge-title.js.es6 b/app/assets/javascripts/discourse/controllers/preferences/badge-title.js.es6 index 85e3613d346..98be7cd39d3 100644 --- a/app/assets/javascripts/discourse/controllers/preferences/badge-title.js.es6 +++ b/app/assets/javascripts/discourse/controllers/preferences/badge-title.js.es6 @@ -19,7 +19,9 @@ export default Ember.ArrayController.extend({ }.property('saving'), selectableUserBadges: function() { - var items = this.get('model').filterBy('badge.allow_title', true); + var items = new Array(); + this.get('model').filterBy('badge.allow_title', true).forEach(function(item, index, arr) { + if(!items.findBy('badge.name', item.badge.name)) items.push(item); }); items.unshiftObject(Em.Object.create({ badge: Discourse.Badge.create({name: I18n.t('badges.no_title')}) }));