mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FEATURE: log long running jobs in the defer queue
If a job in the defer queue takes longer than 90 seconds log an error
This commit is contained in:
@@ -14,6 +14,26 @@ describe Scheduler::Defer do
|
||||
end
|
||||
end
|
||||
|
||||
class TrackingLogger < ::Logger
|
||||
attr_reader :messages
|
||||
def initialize
|
||||
super(nil)
|
||||
@messages = []
|
||||
end
|
||||
def add(*args, &block)
|
||||
@messages << args
|
||||
end
|
||||
end
|
||||
|
||||
def track_log_messages
|
||||
old_logger = Rails.logger
|
||||
logger = Rails.logger = TrackingLogger.new
|
||||
yield logger.messages
|
||||
logger.messages
|
||||
ensure
|
||||
Rails.logger = old_logger
|
||||
end
|
||||
|
||||
before do
|
||||
@defer = DeferInstance.new
|
||||
@defer.async = true
|
||||
@@ -23,6 +43,26 @@ describe Scheduler::Defer do
|
||||
@defer.stop!
|
||||
end
|
||||
|
||||
it "supports timeout reporting" do
|
||||
@defer.timeout = 0.05
|
||||
|
||||
m = track_log_messages do |messages|
|
||||
10.times do
|
||||
@defer.later("fast job") {}
|
||||
end
|
||||
@defer.later "weird slow job" do
|
||||
sleep
|
||||
end
|
||||
|
||||
wait_for(100) do
|
||||
messages.length == 1
|
||||
end
|
||||
end
|
||||
|
||||
expect(m.length).to eq(1)
|
||||
expect(m[0][2]).to include("weird slow job")
|
||||
end
|
||||
|
||||
it "can pause and resume" do
|
||||
x = 1
|
||||
@defer.pause
|
||||
|
||||
Reference in New Issue
Block a user