FIX: EmailValidator needs to validate format of email.

spec/models/invite_spec.rb

@@ -29,9 +29,9 @@ describe Invite do
     fab!(:coding_horror) { Fabricate(:coding_horror) }
 
     it "should not allow an invite with unformatted email address" do
-      expect {
-        Fabricate(:invite, email: "John Doe <john.doe@example.com>")
-      }.to raise_error(ActiveRecord::RecordInvalid)
+      invite = Fabricate.build(:invite, email: "John Doe <john.doe@example.com>")
+      expect(invite.valid?).to eq(false)
+      expect(invite.errors.details[:email].first[:error]).to eq(I18n.t("user.email.invalid"))
     end
 
     it "should not allow an invite with blacklisted email" do
@@ -44,6 +44,11 @@ describe Invite do
       expect(invite).to be_valid
     end
 
+    it "should not allow an invalid email address" do
+      invite = Fabricate.build(:invite, email: 'asjdso')
+      expect(invite.valid?).to eq(false)
+      expect(invite.errors.details[:email].first[:error]).to eq(I18n.t("user.email.invalid"))
+    end
   end
 
   context '#create' do

spec/models/user_email_spec.rb

@@ -3,32 +3,36 @@
 require 'rails_helper'
 
 describe UserEmail do
+  fab!(:user) { Fabricate(:user) }
+
   context "validation" do
     it "allows only one primary email" do
-      user = Fabricate(:user)
       expect {
         Fabricate(:secondary_email, user: user, primary: true)
       }.to raise_error(ActiveRecord::RecordInvalid)
     end
 
     it "allows multiple secondary emails" do
-      user = Fabricate(:user)
       Fabricate(:secondary_email, user: user, primary: false)
       Fabricate(:secondary_email, user: user, primary: false)
       expect(user.user_emails.count).to eq 3
     end
+
+    it "does not allow an invalid email" do
+      user_email = Fabricate.build(:user_email, user: user, email: "asjdaiosd")
+      expect(user_email.valid?).to eq(false)
+      expect(user_email.errors.details[:email].first[:error]).to eq(I18n.t("user.email.invalid"))
+    end
   end
 
   context "indexes" do
     it "allows only one primary email" do
-      user = Fabricate(:user)
       expect {
         Fabricate.build(:secondary_email, user: user, primary: true).save(validate: false)
       }.to raise_error(ActiveRecord::RecordNotUnique)
     end
 
     it "allows multiple secondary emails" do
-      user = Fabricate(:user)
       Fabricate.build(:secondary_email, user: user, primary: false).save(validate: false)
       Fabricate.build(:secondary_email, user: user, primary: false).save(validate: false)
       expect(user.user_emails.count).to eq 3