From 063690d28de9fcc3cf4e06a44d4b76f62000beb3 Mon Sep 17 00:00:00 2001 From: David Taylor Date: Mon, 22 Feb 2021 21:55:15 +0000 Subject: [PATCH] DEV: Correct DeprecatedSettings test cleanup (#12177) If this test ran before the new SiteSettingsController spec from 8cd7c9b2593462ad64512ac7e4bd208a4d560fa3, it would fail the run. We need to `dup` the array before calling `.clear` on the original --- spec/models/site_setting_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/models/site_setting_spec.rb b/spec/models/site_setting_spec.rb index 9b87678b3fd..cf9b5174b45 100644 --- a/spec/models/site_setting_spec.rb +++ b/spec/models/site_setting_spec.rb @@ -163,7 +163,7 @@ describe SiteSetting do it 'should act as a proxy to the new methods' do begin - original_settings = SiteSettings::DeprecatedSettings::SETTINGS + original_settings = SiteSettings::DeprecatedSettings::SETTINGS.dup SiteSettings::DeprecatedSettings::SETTINGS.clear SiteSettings::DeprecatedSettings::SETTINGS.push([