IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Adding form template to category dropdown can some times be empty (#25066)

Browse Source 
Why this change?

A system test which was testing our ability to add a form template to a
category was flaky. This turned out to be a client side bug where the
`FormTemplateChooser` dropdown may not display any dropdown options if
the ajax request to fetch the categories form template has not been
completed when the dropdown is opened.

What does this change do?

Make use of select-kit's `triggerSearch` function to fetch the records
which will properly rerender the dropdown options.
This commit is contained in:
Alan Guo Xiang Tan 2023-12-29 14:15:56 +08:00 committed by GitHub
parent ea910e291b
commit 0756486b65
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 37 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

60
app/assets/javascripts/select-kit/addon/components/form-template-chooser.js
View File

@ -11,43 +11,57 @@ export default MultiSelectComponent.extend({
init() {
this._super(...arguments);
if (!this.templates) {
this._fetchTemplates();
}
this.triggerSearch();
},
didUpdateAttrs() {
this._super(...arguments);
this._fetchTemplates();
this.set("templatesLoaded", false);
this.triggerSearch();
},
@computed("templates")
get content() {
if (!this.templates) {
return this._fetchTemplates();
}
return this.templates;
},
_fetchTemplates() {
FormTemplate.findAll().then((result) => {
let sortedTemplates = this._sortTemplatesByName(result);
search(filter) {
if (this.get("templatesLoaded")) {
return this._super(filter);
} else {
return this._fetchTemplates();
}
},
if (this.filteredIds) {
sortedTemplates = sortedTemplates.filter((t) =>
this.filteredIds.includes(t.id)
);
}
async _fetchTemplates() {
if (this.get("loadingTemplates")) {
return;
}
if (sortedTemplates.length > 0) {
return this.set("templates", sortedTemplates);
} else {
this.set("templates", sortedTemplates);
this.set("selectKit.options.disabled", true);
}
this.set("templatesLoaded", false);
this.set("loadingTemplates", true);
const result = await FormTemplate.findAll();
let sortedTemplates = this._sortTemplatesByName(result);
if (this.filteredIds) {
sortedTemplates = sortedTemplates.filter((t) =>
this.filteredIds.includes(t.id)
);
}
if (sortedTemplates.length === 0) {
this.set("selectKit.options.disabled", true);
}
this.setProperties({
templates: sortedTemplates,
loadingTemplates: false,
templatesLoaded: true,
});
return this.templates;
},
_sortTemplatesByName(templates) {