IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Improve code comment about when ignored columns can be removed (#26894)

Browse Source 
Ignored columns can only be dropped when its associated post-deploy
migration has been promoted to a regular migration. This is so because
Discourse doesn't rely on a schema file system to setup a brand new
database and thus the column information will be loaded by the
application first before the post-deploy migration runs.
This commit is contained in:
Alan Guo Xiang Tan
2024-05-07 11:06:31 +08:00
committed by GitHub
parent 2347ff7074
commit 0b947b6aab
15 changed files with 19 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/migration/safe_migrate.rb
View File

@@ -141,7 +141,7 @@ class Migration::SafeMigrate
or rename columns.
Note, to minimize disruption use self.ignored_columns = ["column name"] on your
ActiveRecord model, this can be removed 6 months or so later.
ActiveRecord model, this can be removed after the post deployment migration has been promoted to a regular migration.
This protection is in place to protect us against dropping columns that are currently
in use by live applications.