IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

A11Y: improve about page profile link markup (#23695)

Browse Source
This commit is contained in:
Kris 2023-10-02 13:55:28 -04:00 committed by GitHub
parent 5884176174
commit 0bb7e9e0b8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 29 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
app/assets/javascripts/discourse/app/components/about-page-users.hbs
View File

@ -1,34 +1,32 @@
{{#each this.usersTemplates as |userTemplate|}} {{#each this.usersTemplates as |userTemplate|}}
<div data-username={{userTemplate.username}} class="user-info small"> <a
<div class="user-image"> href={{userTemplate.userPath}}
<div class="user-image-inner"> data-user-card={{userTemplate.username}}
<a aria-label={{i18n "user.profile_possessive" username=userTemplate.username}}
href={{userTemplate.userPath}} >
data-user-card={{userTemplate.username}} <div data-username={{userTemplate.username}} class="user-info small">
> <div class="user-image">
<div class="user-image-inner">
{{html-safe userTemplate.avatar}} {{html-safe userTemplate.avatar}}
</a>
</div>
</div> </div>
</div> <div class="user-detail">
<div class="user-detail"> <div class="name-line">
<div class="name-line"> <span class="username">
<span class="username">
<a
href={{userTemplate.userPath}}
data-user-card={{userTemplate.username}}
>
{{#if {{#if
userTemplate.prioritizeName userTemplate.prioritizeName
}}{{userTemplate.name}}{{else}}{{userTemplate.username}}{{/if}} }}{{userTemplate.name}}{{else}}{{userTemplate.username}}{{/if}}
</a> </span>
</span> <span class="name">
<span class="name"> {{#if
{{#if userTemplate.prioritizeName
userTemplate.prioritizeName }}{{userTemplate.username}}{{else}}{{userTemplate.name}}{{/if}}
}}{{userTemplate.username}}{{else}}{{userTemplate.name}}{{/if}} </span>
</span> </div>
<div class="title">{{userTemplate.title}}</div>
</div> </div>
<div class="title">{{userTemplate.title}}</div>
</div> </div>
</div> </a>
{{/each}} {{/each}}

18
app/assets/stylesheets/common/components/user-info.scss
View File

@ -25,24 +25,16 @@
.name-line { .name-line {
@include ellipsis; @include ellipsis;
} color: var(--primary-high);
.bold a { span:first-child {
font-weight: bold; color: var(--primary);
} }
.margin a {
margin-left: 5px;
}
.name a,
.username a {
color: var(--primary-high-or-secondary-low);
} }
.title { .title {
margin-top: 3px; margin-top: 3px;
color: var(--primary-med-or-secondary-med); color: var(--primary-medium);
} }
} }

1
config/locales/client.en.yml
View File

@ -1076,6 +1076,7 @@ en:
user: user:
said: "%{username}:" said: "%{username}:"
profile: "Profile" profile: "Profile"
profile_possessive: "%{username}'s profile"
mute: "Mute" mute: "Mute"
edit: "Edit Preferences" edit: "Edit Preferences"
download_archive: download_archive: