PERF: don't load User object in memory when we only need to know if it exists

lib/pretty_text/helpers.rb

@@ -31,9 +31,8 @@ module PrettyText
 
     def mention_lookup(name)
       return false   if name.blank?
-      return "group" if Group.where(name: name).exists?
+      return "group" if Group.exists?(name: name)
-      return "user"  if User.where(username_lower: name.downcase).exists?
+      return "user"  if User.exists?(username_lower: name.downcase)
-      nil
     end
 
     def category_hashtag_lookup(category_slug)
@@ -70,9 +69,8 @@ module PrettyText
     end
 
     def get_current_user(user_id)
-      user = User.find_by(id: user_id)
+      return unless Fixnum === user_id
-      staff = user ? user.staff? : false
+      { staff: User.where(id: user_id).where("moderator OR admin").exists? }
-      { staff: staff }
     end
   end
 end