mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
FEATURE: Add support for secure media (#7888)
This PR introduces a new secure media setting. When enabled, it prevent unathorized access to media uploads (files of type image, video and audio). When the `login_required` setting is enabled, then all media uploads will be protected from unauthorized (anonymous) access. When `login_required`is disabled, only media in private messages will be protected from unauthorized access. A few notes: - the `prevent_anons_from_downloading_files` setting no longer applies to audio and video uploads - the `secure_media` setting can only be enabled if S3 uploads are already enabled and configured - upload records have a new column, `secure`, which is a boolean `true/false` of the upload's secure status - when creating a public post with an upload that has already been uploaded and is marked as secure, the post creator will raise an error - when enabling or disabling the setting on a site with existing uploads, the rake task `uploads:ensure_correct_acl` should be used to update all uploads' secure status and their ACL on S3
This commit is contained in:
committed by
Martin Brennan
parent
56b19ba740
commit
102909edb3
@@ -30,9 +30,9 @@ class TopicConverter
|
||||
)
|
||||
|
||||
update_user_stats
|
||||
update_post_uploads_secure_status
|
||||
Jobs.enqueue(:topic_action_converter, topic_id: @topic.id)
|
||||
Jobs.enqueue(:delete_inaccessible_notifications, topic_id: @topic.id)
|
||||
|
||||
watch_topic(topic)
|
||||
end
|
||||
@topic
|
||||
@@ -49,6 +49,7 @@ class TopicConverter
|
||||
)
|
||||
|
||||
add_allowed_users
|
||||
update_post_uploads_secure_status
|
||||
|
||||
Jobs.enqueue(:topic_action_converter, topic_id: @topic.id)
|
||||
Jobs.enqueue(:delete_inaccessible_notifications, topic_id: @topic.id)
|
||||
@@ -97,4 +98,11 @@ class TopicConverter
|
||||
end
|
||||
end
|
||||
|
||||
def update_post_uploads_secure_status
|
||||
@topic.posts.each do |post|
|
||||
next if post.uploads.empty?
|
||||
post.update_uploads_secure_status
|
||||
post.rebake!
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user