IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: Do not use generic username suggestions for invites (#31175)

Browse Source 
6fd577d97d widened the scope of
`use_email_for_username_and_name_suggestions` (default false) to include
invites, which means that it fell back to a generic username like
`user1`.

This commit makes it bail out earlier in this situation, so that no
suggestion is attempted.
This commit is contained in:
David Taylor
2025-02-07 10:52:41 +00:00
committed by GitHub
parent e55c7700ff
commit 117027a40a
3 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
spec/system/signup_spec.rb
View File

@@ -269,6 +269,7 @@ shared_examples "signup scenarios" do |signup_page_object, login_page_object|
visit "/invites/#{invite.invite_key}?t=#{invite.email_token}"
find("#new-account-password").fill_in(with: "supersecurepassword")
find("#new-account-username").fill_in(with: "johndoe")
find(".username-input").has_css?("#username-validation.good")
find(".create-account__password-tip-validation").has_css?("#password-validation.good")
find(".invitation-cta__accept").click