From 11b421525c61fe90b77195b089be477ceab625c9 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Mon, 16 Aug 2021 12:18:26 +0800 Subject: [PATCH] DEV: Remove an unnecessary join in `TopicTrackingState.report` take 2. This reverts commit f438cb8e65b2239a4410de5f43a35e2e67b775d2. --- app/models/topic_tracking_state.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/models/topic_tracking_state.rb b/app/models/topic_tracking_state.rb index 608c8f35eee..3051cbb8931 100644 --- a/app/models/topic_tracking_state.rb +++ b/app/models/topic_tracking_state.rb @@ -475,8 +475,8 @@ class TopicTrackingState JOIN user_options AS uo ON uo.user_id = u.id JOIN categories c ON c.id = topics.category_id LEFT JOIN topic_users tu ON tu.topic_id = topics.id AND tu.user_id = u.id - LEFT JOIN category_users ON category_users.category_id = topics.category_id AND category_users.user_id = #{user.id} - LEFT JOIN dismissed_topic_users ON dismissed_topic_users.topic_id = topics.id AND dismissed_topic_users.user_id = #{user.id} + LEFT JOIN category_users ON category_users.category_id = topics.category_id AND category_users.user_id = :user_id + #{skip_new ? "" : "LEFT JOIN dismissed_topic_users ON dismissed_topic_users.topic_id = topics.id AND dismissed_topic_users.user_id = :user_id"} #{additional_join_sql} WHERE u.id = :user_id AND #{filter_old_unread_sql}