FIX: Allow private media uploads to be reused in login_required sites

In non-login-required sites, we prevent secure uploads already used in PMs from being used in public topics.

In login_required sites, secure uploads should be reusable in any topic, PM or not.
This commit is contained in:
Penar Musaraj
2019-11-21 09:13:33 -05:00
parent cc0df69ea6
commit 11d22293fb
2 changed files with 13 additions and 1 deletions

View File

@@ -898,7 +898,7 @@ class Post < ActiveRecord::Base
upload_ids |= Upload.where(id: downloaded_images.values).pluck(:id)
disallowed_uploads = []
if SiteSetting.secure_media? && !topic&.private_message?
if SiteSetting.secure_media? && !self.with_secure_media?
disallowed_uploads = Upload.where(id: upload_ids, secure: true).pluck(:original_filename)
end
return disallowed_uploads if disallowed_uploads.count > 0