IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 01:16:38 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Destroying a user failed when it had title

Browse Source 
...because updating the user caused a validation of the primary email and the UserEmail records are already deleted at that time.
This commit is contained in:
Gerhard Schlager 2020-05-24 22:12:55 +02:00
parent 058bf56b4c
commit 13d5ccedf5
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/group_user.rb
View File

@ -38,7 +38,7 @@ class GroupUser < ActiveRecord::Base
def grant_other_available_title def grant_other_available_title
if group.title.present? && group.title == user.title if group.title.present? && group.title == user.title
user.update!(title: user.next_best_title) user.update_attribute(:title, user.next_best_title)
end end
end end

8
spec/models/group_spec.rb
View File

@ -502,6 +502,14 @@ describe Group do
expect(user.title).to eq('Different') expect(user.title).to eq('Different')
expect(user.primary_group).to eq(primary_group) expect(user.primary_group).to eq(primary_group)
end end
it "doesn't fail when the user gets destroyed" do
group.update(title: 'Awesome')
group.add(user)
user.reload
UserDestroyer.new(Discourse.system_user).destroy(user)
end
end end
it "has custom fields" do it "has custom fields" do