IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

PERF: Improve cook_url performance for topic thumbnails (#11609)

Browse Source 
- Only initialize the S3Helper when needed
- Skip initializing the S3Helper for S3Store#cdn_url
- Allow cook_url to be passed a `local` hint to skip unnecessary checks
This commit is contained in:
David Taylor
2020-12-30 18:13:13 +00:00
committed by GitHub
parent 1cd6ff15dc
commit 13e39d8b9f
5 changed files with 25 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/topic.rb
View File

@@ -88,7 +88,7 @@ class Topic < ActiveRecord::Base
Jobs.enqueue(:generate_topic_thumbnails, { topic_id: id, extra_sizes: extra_sizes })
end
infos.each { |i| i[:url] = UrlHelper.cook_url(i[:url], secure: original.secure?) }
infos.each { |i| i[:url] = UrlHelper.cook_url(i[:url], secure: original.secure?, local: true) }
infos.sort_by! { |i| -i[:width] * i[:height] }
end
@@ -123,7 +123,7 @@ class Topic < ActiveRecord::Base
end
raw_url = thumbnail&.optimized_image&.url || image_upload&.url
UrlHelper.cook_url(raw_url, secure: image_upload&.secure?)
UrlHelper.cook_url(raw_url, secure: image_upload&.secure?, local: true) if raw_url
end
def featured_users