IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Prefer public_send over send.

Browse Source
This commit is contained in:
Guo Xiang Tan
2019-05-07 09:27:05 +08:00
parent 9be70a22cd
commit 152238b4cf
74 changed files with 216 additions and 129 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/controllers/admin/badges_controller.rb
View File

@@ -108,7 +108,7 @@ class Admin::BadgesController < Admin::AdminController
params.permit(*allowed)
allowed.each do |key|
badge.send("#{key}=" , params[key]) if params[key]
badge.public_send("#{key}=" , params[key]) if params[key]
end
# Badge query contract checks

6
app/controllers/admin/email_controller.rb
View File

@@ -113,7 +113,11 @@ class Admin::EmailController < Admin::AdminController
params.require(:username)
params.require(:email)
user = User.find_by_username(params[:username])
message, skip_reason = UserNotifications.send(:digest, user, since: params[:last_seen_at])
message, skip_reason = UserNotifications.public_send(:digest, user,
since: params[:last_seen_at]
)
if message
message.to = params[:email]
begin

2
app/controllers/admin/embedding_controller.rb
View File

@@ -16,7 +16,7 @@ class Admin::EmbeddingController < Admin::AdminController
end
Embedding.settings.each do |s|
@embedding.send("#{s}=", params[:embedding][s])
@embedding.public_send("#{s}=", params[:embedding][s])
end
if @embedding.save

2
app/controllers/admin/themes_controller.rb
View File

@@ -157,7 +157,7 @@ class Admin::ThemesController < Admin::AdminController
[:name, :color_scheme_id, :user_selectable].each do |field|
if theme_params.key?(field)
@theme.send("#{field}=", theme_params[field])
@theme.public_send("#{field}=", theme_params[field])
end
end

2
app/controllers/admin/user_fields_controller.rb
View File

@@ -27,7 +27,7 @@ class Admin::UserFieldsController < Admin::AdminController
Admin::UserFieldsController.columns.each do |col|
unless field_params[col].nil?
field.send("#{col}=", field_params[col])
field.public_send("#{col}=", field_params[col])
end
end
update_options(field)

2
app/controllers/admin/users_controller.rb
View File

@@ -254,7 +254,7 @@ class Admin::UsersController < Admin::AdminController
level = params[:level].to_i
if @user.manual_locked_trust_level.nil?
if [0, 1, 2].include?(level) && Promotion.send("tl#{level + 1}_met?", @user)
if [0, 1, 2].include?(level) && Promotion.public_send("tl#{level + 1}_met?", @user)
@user.manual_locked_trust_level = level
@user.save
elsif level == 3 && Promotion.tl3_lost?(@user)