From 175f6f6a14248b7997818daf5050fe2f45118e13 Mon Sep 17 00:00:00 2001 From: David Battersby Date: Tue, 8 Aug 2023 11:48:20 +0800 Subject: [PATCH] FIX: allow lightbox cleanup on navigation changes (#22954) Use dom:clean event to trigger lightbox clean up on navigation changes --- app/assets/javascripts/discourse/app/lib/lightbox/constants.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/assets/javascripts/discourse/app/lib/lightbox/constants.js b/app/assets/javascripts/discourse/app/lib/lightbox/constants.js index 04472c0189a..45e466f1b32 100644 --- a/app/assets/javascripts/discourse/app/lib/lightbox/constants.js +++ b/app/assets/javascripts/discourse/app/lib/lightbox/constants.js @@ -52,8 +52,7 @@ export const SELECTORS = { }; export const LIGHTBOX_APP_EVENT_NAMES = { - // this cannot use dom:clean else #cleanupLightboxes will be called after #setupLightboxes - CLEAN: "lightbox:clean", + CLEAN: "dom:clean", CLOSE: "lightbox:close", CLOSED: "lightbox:closed", ITEM_DID_CHANGE: "lightbox:item-did-change",