diff --git a/app/assets/javascripts/discourse/app/widgets/search-menu.js b/app/assets/javascripts/discourse/app/widgets/search-menu.js index ca44e882354..00f98ada54a 100644 --- a/app/assets/javascripts/discourse/app/widgets/search-menu.js +++ b/app/assets/javascripts/discourse/app/widgets/search-menu.js @@ -348,8 +348,10 @@ export default createWidget("search-menu", { }); }, - mouseDownOutside() { - this.sendWidgetAction("toggleSearchMenu"); + clickOutside() { + if (this.key === "search-menu" && !window.getSelection().toString()) { + this.sendWidgetAction("toggleSearchMenu"); + } }, clearTopicContext() { diff --git a/app/assets/javascripts/discourse/tests/acceptance/search-test.js b/app/assets/javascripts/discourse/tests/acceptance/search-test.js index 90573f61eb0..af531e0aec4 100644 --- a/app/assets/javascripts/discourse/tests/acceptance/search-test.js +++ b/app/assets/javascripts/discourse/tests/acceptance/search-test.js @@ -15,7 +15,7 @@ import { import I18n from "I18n"; import searchFixtures from "discourse/tests/fixtures/search-fixtures"; import selectKit from "discourse/tests/helpers/select-kit-helper"; -import { skip, test } from "qunit"; +import { test } from "qunit"; import { DEFAULT_TYPE_FILTER } from "discourse/widgets/search-menu"; acceptance("Search - Anonymous", function (needs) { @@ -114,8 +114,7 @@ acceptance("Search - Anonymous", function (needs) { ); }); - // TODO: This feature doesn't work currently (/t/69760) - skip("search button toggles search menu", async function (assert) { + test("search button toggles search menu", async function (assert) { await visit("/"); await click("#search-button");