IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: Revert #30547 UX: use em units for code font-size (#30936)

Browse Source 
The solution in (https://github.com/discourse/discourse/pull/30547)
using `em` units was causing readability problems for code blocks in
mobile. This reverts to the previous solution
(https://github.com/discourse/discourse/pull/30536) of using `font-size:
inherit` for code within heading elements.

The downside is that the code in heading won't be slightly smaller than
the other text like it is for inline code in paragraphs, but it seems
worth it to avoid causing other size issues.
This commit is contained in:
Bryce Huhtala 2025-01-22 20:09:23 -05:00 committed by GitHub
parent 99b0ae2fc1
commit 1820dd34fc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
app/assets/stylesheets/common/base/code_highlighting.scss
View File

@ -19,7 +19,7 @@ code {
color: var(--primary-very-high);
background: var(--hljs-bg);
border-radius: var(--d-border-radius);
font-size: 0.875em;
font-size: 14px;
line-height: calc((13 + 4) / 13);
}
@ -29,6 +29,15 @@ pre > code {
max-height: 500px;
}
h1 code,
h2 code,
h3 code,
h4 code,
h5 code,
h6 code {
font-size: inherit;
}
.hljs-comment,
.hljs-doctag,
.hljs-code,