FIX: more reliable native sharing (#7039)

app/assets/javascripts/discourse/initializers/topic-footer-buttons.js.es6

@@ -6,34 +6,6 @@ export default {
   name: "topic-footer-buttons",
 
   initialize() {
-    registerTopicFooterButton({
-      id: "native-share",
-      icon: "link",
-      priority: 999,
-      label: "topic.share.title",
-      title: "topic.share.help",
-      action() {
-        nativeShare({ url: this.get("topic.shareUrl") }).catch(() =>
-          showModal("share-and-invite", {
-            modalClass: "share-and-invite",
-            panels: [
-              {
-                id: "share",
-                title: "topic.share.title",
-                model: { topic: this.get("topic") }
-              }
-            ]
-          })
-        );
-      },
-      dropdown: true,
-      classNames: ["native-share"],
-      dependentKeys: ["topic.shareUrl", "topic.isPrivateMessage"],
-      displayed() {
-        return window.navigator.share;
-      }
-    });
-
     registerTopicFooterButton({
       id: "share-and-invite",
       icon: "link",
@@ -79,13 +51,7 @@ export default {
           });
         };
 
-        if (window.navigator.share) {
+        nativeShare({ url: this.get("topic.shareUrl") }).then(null, modal);
-          window.navigator
-            .share({ url: this.get("topic.shareUrl") })
-            .catch(() => modal());
-        } else {
-          modal();
-        }
       },
       dropdown() {
         return this.site.mobileView;
@@ -98,10 +64,7 @@ export default {
         "inviteDisabled",
         "isPM",
         "invitingToTopic"
-      ],
+      ]
-      displayed() {
-        return !(this.site.mobileView && window.navigator.share);
-      }
     });
 
     registerTopicFooterButton({

app/assets/javascripts/discourse/lib/pwa-utils.js.es6

@@ -6,8 +6,14 @@ export function nativeShare(data) {
     ) {
       window.navigator
         .share(data)
-        .catch(reject)
+        .then(resolve)
-        .then(resolve);
+        .catch(e => {
+          if (e.message === "Share canceled") {
+            // closing share panel do nothing
+          } else {
+            reject();
+          }
+        });
     } else {
       reject();
     }

app/assets/javascripts/discourse/widgets/post.js.es6

@@ -280,9 +280,7 @@ createWidget("post-date", {
       });
     };
 
-    // use native webshare when available
+    nativeShare({ url: this.attrs.shareUrl }).then(null, modalFallback);
-    // navigator.share needs HTTPS, returns undefined on HTTP
-    nativeShare({ url: this.attrs.shareUrl }).catch(modalFallback);
   }
 });