IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Link to category settings should use slug

Browse Source 
Links to category settings were created using the category name. If the name was a single word, the link would be valid (regardless of capitalization).

For example, if the category was named `Awesome`

`/c/Awesome/edit/settings`

is a valid URL as that is a case-insensitive match for the category slug of `awesome`.

However, if the category had a space in it, the URL would be

`/c/Awesome%20Name/edit/settings`

which does not match the slug of `awesome-name`.

This change uses the category slug, rather than the name, which is the expected behaviour (see `Category.find_by_slug_path`).
This commit is contained in:
Jamie Wilson
2023-01-05 15:38:32 -05:00
committed by Alan Guo Xiang Tan
parent c4ea158656
commit 19a0bdc0ee
3 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/serializers/reviewable_score_serializer.rb
View File

@@ -72,7 +72,7 @@ class ReviewableScoreSerializer < ApplicationSerializer
when 'watched_word'
"#{Discourse.base_url}/admin/customize/watched_words"
when 'category'
"#{Discourse.base_url}/c/#{object.reviewable.category&.name}/edit/settings"
"#{Discourse.base_url}/c/#{object.reviewable.category&.slug}/edit/settings"
else
"#{Discourse.base_url}/admin/site_settings/category/all_results?filter=#{text}"
end