IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Standardize table sorting verbiage (#9757)

Browse Source 
* DEV: Standardize table sorting verbiage

This commit creates a common component that tables can use to make their
headers sortable. This commit also standardizes on using `desc` as the
default and passing in the `asc=true` flag to adjust the sorting
direction.

* Add deprecation warnings

Adds deprecation warnings if using previous params and maintains
backwards compatibility. Set the default sort value for group members to
be asc.

* switch group requests to use common table-header-toggle

* update fixture
This commit is contained in:
Blake Erickson
2020-05-14 20:10:59 -06:00
committed by GitHub
parent 11cd149122
commit 1a2b9435b0
18 changed files with 49 additions and 106 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/admin/templates/components/admin-directory-toggle.hbs
View File

@@ -1 +0,0 @@
<span class="header-contents">{{i18n this.i18nKey}}{{chevronIcon}}</span>

16
app/assets/javascripts/admin/templates/users-list-show.hbs
View File

@@ -23,14 +23,14 @@
{{#if model}}
<table class="table users-list grid">
<thead>
{{admin-directory-toggle field="username" i18nKey="username" order=order ascending=ascending}}
{{admin-directory-toggle field="email" i18nKey="email" order=order ascending=ascending}}
{{admin-directory-toggle field="last_emailed" i18nKey="admin.users.last_emailed" order=order ascending=ascending}}
{{admin-directory-toggle field="seen" i18nKey="last_seen" order=order ascending=ascending}}
{{admin-directory-toggle field="topics_viewed" i18nKey="admin.user.topics_entered" order=order ascending=ascending}}
{{admin-directory-toggle field="posts_read" i18nKey="admin.user.posts_read_count" order=order ascending=ascending}}
{{admin-directory-toggle field="read_time" i18nKey="admin.user.time_read" order=order ascending=ascending}}
{{admin-directory-toggle field="created" i18nKey="created" order=order ascending=ascending}}
{{table-header-toggle field="username" labelKey="username" order=order asc=asc}}
{{table-header-toggle field="email" labelKey="email" order=order asc=asc}}
{{table-header-toggle field="last_emailed" labelKey="admin.users.last_emailed" order=order asc=asc}}
{{table-header-toggle field="seen" labelKey="last_seen" order=order asc=asc}}
{{table-header-toggle field="topics_viewed" labelKey="admin.user.topics_entered" order=order asc=asc}}
{{table-header-toggle field="posts_read" labelKey="admin.user.posts_read_count" order=order asc=asc}}
{{table-header-toggle field="read_time" labelKey="admin.user.time_read" order=order asc=asc}}
{{table-header-toggle field="created" labelKey="created" order=order asc=asc}}
{{#if siteSettings.must_approve_users}}
<th>{{i18n "admin.users.approved"}}</th>
{{/if}}