mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
DEV: Improve specs for validating a unique post.
Follow up to d2a7f29595 which caused post
edits to fail.
This commit is contained in:
@@ -2,7 +2,8 @@ require 'rails_helper'
|
|||||||
require_dependency 'validators/post_validator'
|
require_dependency 'validators/post_validator'
|
||||||
|
|
||||||
describe Validators::PostValidator do
|
describe Validators::PostValidator do
|
||||||
let(:post) { build(:post, topic: Fabricate(:topic)) }
|
let(:topic) { Fabricate(:topic) }
|
||||||
|
let(:post) { build(:post, topic: topic) }
|
||||||
let(:validator) { Validators::PostValidator.new({}) }
|
let(:validator) { Validators::PostValidator.new({}) }
|
||||||
|
|
||||||
context "#post_body_validator" do
|
context "#post_body_validator" do
|
||||||
@@ -186,35 +187,51 @@ describe Validators::PostValidator do
|
|||||||
end
|
end
|
||||||
|
|
||||||
describe "unique_post_validator" do
|
describe "unique_post_validator" do
|
||||||
|
let(:user) { Fabricate(:user, id: 999) }
|
||||||
|
let(:post) { Fabricate(:post, user: user, topic: topic) }
|
||||||
|
|
||||||
before do
|
before do
|
||||||
SiteSetting.unique_posts_mins = 5
|
SiteSetting.unique_posts_mins = 5
|
||||||
|
post.store_unique_post_key
|
||||||
|
@key = post.unique_post_key
|
||||||
|
end
|
||||||
|
|
||||||
|
after do
|
||||||
|
$redis.del(@key)
|
||||||
end
|
end
|
||||||
|
|
||||||
context "post is unique" do
|
context "post is unique" do
|
||||||
before do
|
let(:new_post) do
|
||||||
post.stubs(:matches_recent_post?).returns(false)
|
Fabricate.build(:post, user: user, raw: "unique content", topic: topic)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "should not add an error" do
|
it "should not add an error" do
|
||||||
|
validator.unique_post_validator(new_post)
|
||||||
|
expect(new_post.errors.count).to eq(0)
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'should not add an error when changing an existing post' do
|
||||||
|
post.raw = "changing raw"
|
||||||
|
|
||||||
validator.unique_post_validator(post)
|
validator.unique_post_validator(post)
|
||||||
expect(post.errors.count).to eq(0)
|
expect(post.errors.count).to eq(0)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
context "post is not unique" do
|
context "post is not unique" do
|
||||||
before do
|
let(:new_post) do
|
||||||
post.stubs(:matches_recent_post?).returns(true)
|
Fabricate.build(:post, user: user, raw: post.raw, topic: topic)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "should add an error" do
|
it "should add an error" do
|
||||||
validator.unique_post_validator(post)
|
validator.unique_post_validator(new_post)
|
||||||
expect(post.errors.count).to be > 0
|
expect(new_post.errors.keys).to contain_exactly(:raw)
|
||||||
end
|
end
|
||||||
|
|
||||||
it "should not add an error if post.skip_unique_check is true" do
|
it "should not add an error if post.skip_unique_check is true" do
|
||||||
post.skip_unique_check = true
|
new_post.skip_unique_check = true
|
||||||
validator.unique_post_validator(post)
|
validator.unique_post_validator(new_post)
|
||||||
expect(post.errors.count).to eq(0)
|
expect(new_post.errors.count).to eq(0)
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|||||||
Reference in New Issue
Block a user