IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 09:26:54 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5227 from majakomel/delete-tag-confirm

Browse Source 
UX: Improve Delete Tag Confirm Message
This commit is contained in:
Guo Xiang Tan 2017-10-09 11:26:12 +08:00 committed by GitHub
commit 1d0fadd48c
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/controllers/tags-show.js.es6
View File

@ -115,7 +115,9 @@ export default Ember.Controller.extend(BulkTopicSelection, {
deleteTag() {
const self = this;
bootbox.confirm(I18n.t("tagging.delete_confirm"), function(result) {
const topicsLength = this.get('list.topic_list.topics.length');
const confirmText = topicsLength === 0 ? I18n.t("tagging.delete_confirm_no_topics") : I18n.t("tagging.delete_confirm", {count: topicsLength});
bootbox.confirm(confirmText, function(result) {
if (!result) { return; }
self.get("tag").destroyRecord().then(function() {

5
config/locales/client.en.yml
View File

@ -2459,7 +2459,10 @@ en:
tags: "Tags"
choose_for_topic: "choose optional tags for this topic"
delete_tag: "Delete Tag"
delete_confirm: "Are you sure you want to delete that tag?"
delete_confirm:
one: "Are you sure you want to delete this tag and remove it from 1 topic it is assigned to?"
other: "Are you sure you want to delete this tag and remove it from {{count}} topics it is assigned to?"
delete_confirm_no_topics: "Are you sure you want to delete this tag?"
rename_tag: "Rename Tag"
rename_instructions: "Choose a new name for the tag:"
sort_by: "Sort by:"