IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Hook up chat bulk delete for threads (#21109)

Browse Source 
Followup to bd5c5c4b5f,
this commit hooks up the bulk delete events for chat
messages inside the thread panel, by fanning out the
deleted message IDs based on whether they belong to
a thread or not.

Also adds a system spec to cover this case, as previously
the bulk delete event would have been broken with an incorrect
`typ` rather than `type` hash key.
This commit is contained in:
Martin Brennan
2023-04-18 08:28:20 +10:00
committed by GitHub
parent b869d35f94
commit 1e85de36e2
10 changed files with 222 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

103
plugins/chat/spec/models/chat/thread_spec.rb
View File

@@ -42,4 +42,107 @@ RSpec.describe Chat::Thread do
end
end
end
describe ".grouped_messages" do
fab!(:channel) { Fabricate(:category_channel) }
fab!(:thread_1) { Fabricate(:chat_thread, channel: channel) }
fab!(:thread_2) { Fabricate(:chat_thread, channel: channel) }
fab!(:message_1) { Fabricate(:chat_message, chat_channel: channel, thread: thread_1) }
fab!(:message_2) { Fabricate(:chat_message, chat_channel: channel, thread: thread_1) }
fab!(:message_3) { Fabricate(:chat_message, chat_channel: channel, thread: thread_2) }
let(:result) { Chat::Thread.grouped_messages(**params) }
context "when thread_ids provided" do
let(:params) { { thread_ids: [thread_1.id, thread_2.id] } }
it "groups all the message ids in each thread by thread ID" do
expect(result.find { |res| res.thread_id == thread_1.id }.to_h).to eq(
{
thread_message_ids: [thread_1.original_message_id, message_1.id, message_2.id],
thread_id: thread_1.id,
original_message_id: thread_1.original_message_id,
},
)
expect(result.find { |res| res.thread_id == thread_2.id }.to_h).to eq(
{
thread_message_ids: [thread_2.original_message_id, message_3.id],
thread_id: thread_2.id,
original_message_id: thread_2.original_message_id,
},
)
end
context "when include_original_message is false" do
let(:params) { { thread_ids: [thread_1.id, thread_2.id], include_original_message: false } }
it "does not include the original message in the thread_message_ids" do
expect(result.find { |res| res.thread_id == thread_1.id }.to_h).to eq(
{
thread_message_ids: [message_1.id, message_2.id],
thread_id: thread_1.id,
original_message_id: thread_1.original_message_id,
},
)
end
end
end
context "when message_ids provided" do
let(:params) do
{
message_ids: [
thread_1.original_message_id,
thread_2.original_message_id,
message_1.id,
message_2.id,
message_3.id,
],
}
end
it "groups all the message ids in each thread by thread ID" do
expect(result.find { |res| res.thread_id == thread_1.id }.to_h).to eq(
{
thread_message_ids: [thread_1.original_message_id, message_1.id, message_2.id],
thread_id: thread_1.id,
original_message_id: thread_1.original_message_id,
},
)
expect(result.find { |res| res.thread_id == thread_2.id }.to_h).to eq(
{
thread_message_ids: [thread_2.original_message_id, message_3.id],
thread_id: thread_2.id,
original_message_id: thread_2.original_message_id,
},
)
end
context "when include_original_message is false" do
let(:params) do
{
message_ids: [
thread_1.original_message_id,
thread_2.original_message_id,
message_1.id,
message_2.id,
message_3.id,
],
include_original_message: false,
}
end
it "does not include the original message in the thread_message_ids" do
expect(result.find { |res| res.thread_id == thread_1.id }.to_h).to eq(
{
thread_message_ids: [message_1.id, message_2.id],
thread_id: thread_1.id,
original_message_id: thread_1.original_message_id,
},
)
end
end
end
end
end