DEV: move groups data loading from controller to route (#29130)

app/assets/javascripts/discourse/app/controllers/groups-index.js

@@ -30,17 +30,6 @@ export default class GroupsIndexController extends Controller {
     return types;
   }
 
-  loadGroups(params) {
-    this.set("isLoading", true);
-
-    this.store
-      .findAll("group", params)
-      .then((groups) => {
-        this.set("groups", groups);
-      })
-      .finally(() => this.set("isLoading", false));
-  }
-
   @action
   onFilterChanged(filter) {
     discourseDebounce(this, this._debouncedFilter, filter, INPUT_DELAY);

app/assets/javascripts/discourse/app/routes/groups-index.js

@@ -14,11 +14,13 @@ export default class GroupsIndexRoute extends DiscourseRoute {
     return I18n.t("groups.index.title");
   }
 
-  model(params) {
+  async model(params) {
-    return params;
+    const groups = await this.store.findAll("group", params);
+    return { groups };
   }
 
-  setupController(controller, params) {
+  setupController(controller, model) {
-    controller.loadGroups(params);
+    super.setupController(controller, model);
+    controller.set("groups", model.groups);
   }
 }

app/assets/javascripts/discourse/app/templates/groups/index.hbs

@@ -37,7 +37,6 @@
     </div>
   </div>
 
-  <ConditionalLoadingSpinner @condition={{this.isLoading}}>
   {{#if this.groups}}
     <LoadMore
       @selector=".groups-boxes .group-box"
@@ -122,12 +121,10 @@
         </div>
       </div>
     </LoadMore>
-
     <ConditionalLoadingSpinner @condition={{this.groups.loadingMore}} />
   {{else}}
     <p role="status">{{i18n "groups.index.empty"}}</p>
   {{/if}}
-  </ConditionalLoadingSpinner>
 </section>
 
 <PluginOutlet @name="after-groups-index-container" @connectorTagName="div" />