IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

PERF: Use more efficient text-direction check in select-kit init (#15015)

Browse Source 
Calling `window.getComputedStyle` during initialization causes the browser to pause and 'Recalculate Style'. On my machine, this adds about 7ms to boot time. Instead, we can check for the `rtl` class on the html element, which is added by the server, and doesn't require computing styles.
This commit is contained in:
David Taylor 2021-11-19 10:17:23 +00:00 committed by GitHub
parent 1566cd2048
commit 2153011cdb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/select-kit/addon/components/select-kit.js
View File

@ -27,9 +27,7 @@ const SELECT_KIT_OPTIONS = Mixin.create({
}); });
function isDocumentRTL() { function isDocumentRTL() {
return ( return document.documentElement.classList.contains("rtl");
window.getComputedStyle(document.querySelector("html")).direction === "rtl"
);
} }
export default Component.extend( export default Component.extend(