IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Don't allow category slugs to be entirely digits

Browse Source
This commit is contained in:
Daniel Waterworth 2019-12-04 01:22:29 +00:00
parent 8f708bd6e1
commit 226fc07a17
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/slug.rb
View File

@ -19,8 +19,6 @@ module Slug
when :encoded then self.encoded_generator(string) when :encoded then self.encoded_generator(string)
when :none then self.none_generator(string) when :none then self.none_generator(string)
end end
# Reject slugs that only contain numbers, because they would be indistinguishable from id's.
slug = (slug =~ /[^\d]/ ? slug : '')
slug = self.prettify_slug(slug, max_length: max_length) slug = self.prettify_slug(slug, max_length: max_length)
slug.blank? ? default : slug slug.blank? ? default : slug
end end
@ -33,6 +31,9 @@ module Slug
private private
def self.prettify_slug(slug, max_length:) def self.prettify_slug(slug, max_length:)
# Reject slugs that only contain numbers, because they would be indistinguishable from id's.
slug = (slug =~ /[^\d]/ ? slug : '')
slug slug
.tr("_", "-") .tr("_", "-")
.truncate(max_length, omission: '') .truncate(max_length, omission: '')