FIX: Topic entrance wasn't showing on mobile. Tidied up some stuff.

app/assets/javascripts/discourse/components/basic-topic-list.js.es6

@@ -15,22 +15,45 @@ export default Ember.Component.extend({
     this._initFromTopicList(this.get('topicList'));
   }.observes('topicList.@each'),
 
-  _initFromTopicList: function(topicList) {
+  _initFromTopicList(topicList) {
     if (topicList !== null) {
       this.set('topics', topicList.get('topics'));
       this.rerender();
     }
   },
 
-  init: function() {
+  init() {
     this._super();
-    var topicList = this.get('topicList');
+    const topicList = this.get('topicList');
     if (topicList) {
       this._initFromTopicList(topicList);
     } else {
       // Without a topic list, we assume it's loaded always.
       this.set('loaded', true);
     }
+  },
+
+  click(e) {
+    // Mobile basic-topic-list doesn't use the `topic-list-item` view so
+    // the event for the topic entrance is never wired up.
+    if (!this.site.mobileView) { return; }
+
+    let target = $(e.target);
+
+    if (target.hasClass('posts-map')) {
+      const topicId = target.closest('tr').attr('data-topic-id');
+      if (topicId) {
+        if (target.prop('tagName') !== 'A') {
+          target = target.find('a');
+        }
+
+        const topic = this.get('topics').findProperty('id', parseInt(topicId));
+        this.sendAction('postsAction', {topic, position: target.offset()});
+        // this.container.lookup('controller:application').send("showTopicEntrance", {topic, position: target.offset()});
+      }
+      return false;
+    }
+
   }
 
 });

app/assets/javascripts/discourse/components/topic-list.js.es6

@@ -30,7 +30,7 @@ export default Ember.Component.extend({
     return this.get('order') === "op_likes";
   }.property('order'),
 
-  click: function(e){
+  click(e) {
     var self = this;
     var on = function(sel, callback){
       var target = $(e.target).closest(sel);

app/assets/javascripts/discourse/templates/components/basic-topic-list.hbs

@@ -1,15 +1,13 @@
 {{#conditional-loading-spinner condition=loading}}
   {{#if topics}}
-    {{topic-list
+    {{topic-list showParticipants=showParticipants
-        showParticipants=showParticipants
+                 showPosters=showPosters
-        showPosters=showPosters
+                 hideCategory=hideCategory
-        hideCategory=hideCategory
+                 topics=topics
-        topics=topics
+                 expandExcerpts=expandExcerpts
-        expandExcerpts=expandExcerpts
+                 bulkSelectEnabled=bulkSelectEnabled
-        bulkSelectEnabled=bulkSelectEnabled
+                 canBulkSelect=canBulkSelect
-        canBulkSelect=canBulkSelect
+                 selected=selected}}
-        selected=selected
-    }}
   {{else}}
     {{#unless loadingMore}}
     <div class='alert alert-info'>

app/assets/javascripts/discourse/templates/components/topic-list.hbs

@@ -1,19 +1,18 @@
 {{#unless skipHeader}}
-<thead>
+  <thead>
-  {{raw "topic-list-header"
+    {{raw "topic-list-header" currentUser=currentUser
-        currentUser=currentUser
+                              canBulkSelect=canBulkSelect
-        canBulkSelect=canBulkSelect
+                              toggleInTitle=toggleInTitle
-        toggleInTitle=toggleInTitle
+                              hideCategory=hideCategory
-        hideCategory=hideCategory
+                              showPosters=showPosters
-        showPosters=showPosters
+                              showLikes=showLikes
-        showLikes=showLikes
+                              showOpLikes=showOpLikes
-        showOpLikes=showOpLikes
+                              showParticipants=showParticipants
-        showParticipants=showParticipants
+                              order=order
-        order=order
+                              ascending=ascending
-        ascending=ascending
+                              sortable=sortable
-        sortable=sortable
+                              bulkSelectEnabled=bulkSelectEnabled}}
-        bulkSelectEnabled=bulkSelectEnabled}}
+  </thead>
-</thead>
 {{/unless}}
 <tbody>
   {{each topic in topics itemView="topic-list-item"}}

app/assets/javascripts/discourse/templates/list/topic-list-item.raw.hbs

@@ -1,7 +1,7 @@
 {{#if controller.bulkSelectEnabled}}
-<td class='star'>
+  <td class='star'>
-  <input type="checkbox" class="bulk-select">
+    <input type="checkbox" class="bulk-select">
-</td>
+  </td>
 {{/if}}
 
 <td class='main-link clearfix' colspan="{{titleColSpan}}">
@@ -36,18 +36,18 @@
 {{#if controller.showLikes}}
 <td class="num likes">
   {{#if hasLikes}}
-  <a href='{{topic.summaryUrl}}'>
+    <a href='{{topic.summaryUrl}}'>
-    {{number topic.like_count}} <i class='fa fa-heart'></i></td>
+      {{number topic.like_count}} <i class='fa fa-heart'></i></td>
-  </a>
+    </a>
   {{/if}}
 {{/if}}
 
 {{#if controller.showOpLikes}}
 <td class="num likes">
   {{#if hasOpLikes}}
-  <a href='{{topic.summaryUrl}}'>
+    <a href='{{topic.summaryUrl}}'>
-    {{number topic.op_like_count}} <i class='fa fa-heart'></i></td>
+      {{number topic.op_like_count}} <i class='fa fa-heart'></i></td>
-  </a>
+    </a>
   {{/if}}
 {{/if}}
 

app/assets/javascripts/discourse/templates/mobile/components/basic-topic-list.hbs

@@ -3,7 +3,7 @@
     <table class="topic-list">
       <tbody>
       {{#each t in topics}}
-        <tr {{bind-attr class="t.archived"}}>
+        <tr {{bind-attr class="t.archived"}} data-topic-id={{t.id}}>
           <td>
             <div class='main-link'>
               {{topic-status topic=t}}

app/assets/javascripts/discourse/templates/topic.hbs

@@ -137,13 +137,12 @@
                 <h3>{{{view.suggestedTitle}}}</h3>
                 <div class="topics">
                   {{#if model.isPrivateMessage}}
-                  {{basic-topic-list
+                    {{basic-topic-list hideCategory="true"
-                              hideCategory="true"
+                                       showPosters="true"
-                              showPosters="true"
+                                       topics=model.details.suggested_topics
-                              topics=model.details.suggested_topics
+                                       postsAction="showTopicEntrance"}}
-                              postsAction="showTopicEntrance"}}
                   {{else}}
-                  {{basic-topic-list topics=model.details.suggested_topics postsAction="showTopicEntrance"}}
+                    {{basic-topic-list topics=model.details.suggested_topics postsAction="showTopicEntrance"}}
                   {{/if}}
                 </div>
                 <h3>{{{view.browseMoreMessage}}}</h3>