DEV: Fix ember/require-super-in-lifecycle-hooks (#24007)

and `ember/no-ember-super-in-es-classes`
This commit is contained in:
Jarek Radosz
2023-10-19 13:47:45 +02:00
committed by GitHub
parent ac30673b98
commit 24dc36cf91
26 changed files with 42 additions and 10 deletions

View File

@@ -27,6 +27,7 @@ export default class AceEditor extends Component {
}
didRender() {
super.didRender(...arguments);
this._skipContentChangeEvent = false;
}
@@ -160,9 +161,8 @@ export default class AceEditor extends Component {
}
willDestroyElement() {
if (this._darkModeListener) {
this._darkModeListener.removeListener(this.setAceTheme);
}
super.willDestroyElement(...arguments);
this._darkModeListener?.removeListener(this.setAceTheme);
}
@bind

View File

@@ -53,6 +53,7 @@ export default class AdminGraph extends Component {
}
didInsertElement() {
super.didInsertElement(...arguments);
loadScript("/javascripts/Chart.min.js").then(() =>
this.refreshChart.apply(this)
);

View File

@@ -117,6 +117,7 @@ export default class InstallTheme extends Component {
}
willDestroy() {
super.willDestroy(...arguments);
this.args.model.clearParams?.();
}

View File

@@ -16,6 +16,7 @@ export default class MergeUsersProgress extends Component {
}
willDestroy() {
super.willDestroy(...arguments);
this.messageBus.unsubscribe("/merge_user", this.onMessage);
}