IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

UX: Stop falling back to topic image on embeds (#18720)

Browse Source 
If linked post (not OP) has no image, it won't fall back to the topic
image anymore.
This commit is contained in:
Jan Cernik
2022-10-24 14:54:02 -03:00
committed by GitHub
parent c421dc0b28
commit 25fbbf4020
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/lib/topic_view_spec.rb
View File

@@ -895,9 +895,9 @@ RSpec.describe TopicView do
post1.update_column(:image_upload_id, op_upload.id)
end
it "uses the topic image as a fallback when posts have no image" do
it "uses the topic image for op and posts image when they have one" do
expect(topic_view_for_post(1).image_url).to end_with(op_upload.url)
expect(topic_view_for_post(2).image_url).to end_with(op_upload.url)
expect(topic_view_for_post(2).image_url).to eq(nil)
expect(topic_view_for_post(3).image_url).to end_with(post3_upload.url)
end
end