From 277eae97e1e04a317606316b8b4928382b4368b9 Mon Sep 17 00:00:00 2001
From: Osama Sayegh <asooomaasoooma90@gmail.com>
Date: Tue, 16 Feb 2021 12:46:46 +0300
Subject: [PATCH] FIX: Use autocomplete=discourse in select-kit to disable
 autocomplete in Chrome (#12094)

Chrome ignores `autocomplete="off"` on input fields, but as a workaround we can supply a nonsensical value (`discourse` or anything else) to the `autocomplete` attribute and it'll disable autocomplete.

Context: https://meta.discourse.org/t/-/107484/66?u=osama and https://meta.discourse.org/t/-/140884/13?u=osama.
---
 .../admin/addon/templates/modal/admin-merge-users-prompt.hbs    | 1 -
 .../app/templates/components/composer-user-selector.hbs         | 1 -
 .../discourse/app/templates/components/invite-panel.hbs         | 1 -
 .../javascripts/discourse/app/templates/modal/change-owner.hbs  | 1 -
 .../addon/templates/components/select-kit/select-kit-filter.hbs | 2 +-
 5 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/app/assets/javascripts/admin/addon/templates/modal/admin-merge-users-prompt.hbs b/app/assets/javascripts/admin/addon/templates/modal/admin-merge-users-prompt.hbs
index 196c375d2c4..458c5b56bcf 100644
--- a/app/assets/javascripts/admin/addon/templates/modal/admin-merge-users-prompt.hbs
+++ b/app/assets/javascripts/admin/addon/templates/modal/admin-merge-users-prompt.hbs
@@ -3,7 +3,6 @@
     <p>{{html-safe (i18n "admin.user.merge.prompt.description" username=username)}}</p>
     {{email-group-user-chooser
       value=targetUsername
-      autocomplete="discourse"
       onChange=(action "updateUsername")
       options=(hash
         maximum=1
diff --git a/app/assets/javascripts/discourse/app/templates/components/composer-user-selector.hbs b/app/assets/javascripts/discourse/app/templates/components/composer-user-selector.hbs
index cb6198778b1..c7a563cb356 100644
--- a/app/assets/javascripts/discourse/app/templates/components/composer-user-selector.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/composer-user-selector.hbs
@@ -1,7 +1,6 @@
 {{email-group-user-chooser
   id="private-message-users"
   tabindex="1"
-  autocomplete="discourse"
   value=splitRecipients
   onChange=(action "updateRecipients")
   options=(hash
diff --git a/app/assets/javascripts/discourse/app/templates/components/invite-panel.hbs b/app/assets/javascripts/discourse/app/templates/components/invite-panel.hbs
index fa808f6ac89..95b360db079 100644
--- a/app/assets/javascripts/discourse/app/templates/components/invite-panel.hbs
+++ b/app/assets/javascripts/discourse/app/templates/components/invite-panel.hbs
@@ -20,7 +20,6 @@
         {{#if allowExistingMembers}}
           {{email-group-user-chooser
             class="invite-user-input"
-            autocomplete="discourse"
             value=invitee
             onChange=(action "updateInvitee")
             options=(hash
diff --git a/app/assets/javascripts/discourse/app/templates/modal/change-owner.hbs b/app/assets/javascripts/discourse/app/templates/modal/change-owner.hbs
index 2665d84734c..e56941d0cf8 100644
--- a/app/assets/javascripts/discourse/app/templates/modal/change-owner.hbs
+++ b/app/assets/javascripts/discourse/app/templates/modal/change-owner.hbs
@@ -11,7 +11,6 @@
     <label></label>
     {{email-group-user-chooser
       value=newOwner
-      autocomplete="discourse"
       autofocus=true
       onChange=(action "updateNewOwner")
       options=(hash
diff --git a/app/assets/javascripts/select-kit/addon/templates/components/select-kit/select-kit-filter.hbs b/app/assets/javascripts/select-kit/addon/templates/components/select-kit/select-kit-filter.hbs
index 57e1d3efcf3..d67c68e441c 100644
--- a/app/assets/javascripts/select-kit/addon/templates/components/select-kit/select-kit-filter.hbs
+++ b/app/assets/javascripts/select-kit/addon/templates/components/select-kit/select-kit-filter.hbs
@@ -3,7 +3,7 @@
     tabindex=-1
     class="filter-input"
     placeholder=placeholder
-    autocomplete="off"
+    autocomplete="discourse"
     autocorrect="off"
     autocapitalize="off"
     spellcheck=false