IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-11 05:25:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Presence bug (#5329)

Browse Source 
* Add failing test case

* FIX: new activity was not triggering cleanup
This commit is contained in:
David Taylor
2017-11-20 15:24:59 +01:00
committed by Régis Hanol
parent 7e841a0495
commit 28073413eb
2 changed files with 26 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/discourse-presence/plugin.rb
+6 -6
View File
@@ -122,9 +122,9 @@ after_initialize do
if topic
guardian.ensure_can_see!(topic)
any_changes = false
any_changes ||= Presence::PresenceManager.remove(type, id, current_user.id)
any_changes ||= Presence::PresenceManager.cleanup(type, id)
removed = Presence::PresenceManager.remove(type, id, current_user.id)
any_removed = Presence::PresenceManager.cleanup(type, id)
any_changes = removed || any_removed
users = Presence::PresenceManager.publish(type, id) if any_changes
end
@@ -144,9 +144,9 @@ after_initialize do
if topic
guardian.ensure_can_see!(topic)
any_changes = false
any_changes ||= Presence::PresenceManager.add(type, id, current_user.id)
any_changes ||= Presence::PresenceManager.cleanup(type, id)
added = Presence::PresenceManager.add(type, id, current_user.id)
any_removed = Presence::PresenceManager.cleanup(type, id)
any_changes = added || any_removed
users = Presence::PresenceManager.publish(type, id) if any_changes