IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

PERF: Faster TL3 promotion replies needed calculation (#10416)

Browse Source 
Removing the LIMIT makes PostgreSQL use index_posts_on_user_id_and_created_at
which is much faster overall.

Before: 22 seconds
After: 100 ms
This commit is contained in:
Rafael dos Santos Silva
2020-08-12 11:28:34 -03:00
committed by GitHub
parent 00a0767c35
commit 28669dfeb2
3 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/models/user_stat.rb
View File

@@ -154,11 +154,9 @@ class UserStat < ActiveRecord::Base
end
# topic_reply_count is a count of posts in other users' topics
def calc_topic_reply_count!(max, start_time = nil)
def calc_topic_reply_count!(start_time = nil)
sql = <<~SQL
SELECT COUNT(*) count
FROM (
SELECT DISTINCT posts.topic_id
SELECT COUNT(DISTINCT posts.topic_id) AS count
FROM posts
INNER JOIN topics ON topics.id = posts.topic_id
WHERE posts.user_id = ?
@@ -166,13 +164,11 @@ class UserStat < ActiveRecord::Base
AND posts.deleted_at IS NULL AND topics.deleted_at IS NULL
AND topics.archetype <> 'private_message'
#{start_time.nil? ? '' : 'AND posts.created_at > ?'}
LIMIT ?
) as user_topic_replies
SQL
if start_time.nil?
DB.query_single(sql, self.user_id, max).first
DB.query_single(sql, self.user_id).first
else
DB.query_single(sql, self.user_id, start_time, max).first
DB.query_single(sql, self.user_id, start_time).first
end
end