Clean up wizard updater API for better plugin use

lib/wizard/step_updater.rb

@@ -2,73 +2,16 @@ class Wizard
   class StepUpdater
     include ActiveModel::Model
 
-    def initialize(current_user, id)
+    attr_accessor :refresh_required
+
+    def initialize(current_user, step)
       @current_user = current_user
-      @id = id
+      @step = step
       @refresh_required = false
     end
 
     def update(fields)
-      updater_method = "update_#{@id.underscore}".to_sym
-      send(updater_method, fields.symbolize_keys) if respond_to?(updater_method)
-    end
-
-    def update_locale(fields)
-      old_locale = SiteSetting.default_locale
-      update_setting_field(:default_locale, fields, :default_locale)
-      @refresh_required = true if old_locale != fields[:default_locale]
-    end
-
-    def update_privacy(fields)
-      update_setting(:login_required, fields[:privacy] == 'restricted')
-      update_setting(:invite_only, fields[:privacy] == 'restricted')
-    end
-
-    def update_forum_title(fields)
-      update_setting_field(:title, fields, :title)
-      update_setting_field(:site_description, fields, :site_description)
-    end
-
-    def update_contact(fields)
-      update_setting_field(:contact_email, fields, :contact_email)
-      update_setting_field(:contact_url, fields, :contact_url)
-      update_setting_field(:site_contact_username, fields, :site_contact_username)
-    end
-
-    def update_colors(fields)
-      scheme_name = fields[:theme_id]
-
-      theme = ColorScheme.themes.find {|s| s[:id] == scheme_name }
-
-      colors = []
-      theme[:colors].each do |name, hex|
-        colors << {name: name, hex: hex[1..-1] }
-      end
-
-      attrs = {
-        enabled: true,
-        name: I18n.t("wizard.step.colors.fields.color_scheme.options.#{scheme_name}"),
-        colors: colors,
-        theme_id: scheme_name
-      }
-
-      scheme = ColorScheme.where(via_wizard: true).first
-      if scheme.present?
-        attrs[:colors] = colors
-        revisor = ColorSchemeRevisor.new(scheme, attrs)
-        revisor.revise
-      else
-        attrs[:via_wizard] = true
-        scheme = ColorScheme.new(attrs)
-        scheme.save!
-      end
-    end
-
-    def update_logos(fields)
-      update_setting_field(:logo_url, fields, :logo_url)
-      update_setting_field(:logo_small_url, fields, :logo_small_url)
-      update_setting_field(:favicon_url, fields, :favicon_url)
-      update_setting_field(:apple_touch_icon_url, fields, :apple_touch_icon_url)
+      @step.updater.call(self, fields) if @step.updater.present?
     end
 
     def success?
@@ -79,18 +22,16 @@ class Wizard
       @refresh_required
     end
 
-    protected
+    def update_setting(id, value)
+      value.strip! if value.is_a?(String)
+      SiteSetting.set_and_log(id, value, @current_user) if SiteSetting.send(id) != value
+    end
 
-      def update_setting(id, value)
-        value.strip! if value.is_a?(String)
-        SiteSetting.set_and_log(id, value, @current_user) if SiteSetting.send(id) != value
-      end
-
-      def update_setting_field(id, fields, field_id)
-        update_setting(id, fields[field_id])
-      rescue Discourse::InvalidParameters => e
-        errors.add(field_id, e.message)
-      end
+    def update_setting_field(id, fields, field_id)
+      update_setting(id, fields[field_id])
+    rescue Discourse::InvalidParameters => e
+      errors.add(field_id, e.message)
+    end
 
   end
 end