IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 01:16:38 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: add nofollow to RSS alternate link in topics and categories (#16013)

Browse Source 
* FEATURE: add nofollow to RSS alternate link in topics and categories

* Rspec tests for category and topic view: add nofollow to RSS alternate link
This commit is contained in:
Ayke Halder 2022-03-09 06:34:02 +01:00 committed by GitHub
parent ca93e5e68b
commit 28bb9e11f4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 43 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/list/list.erb
View File

@ -142,7 +142,7 @@
<% if @category %>
<% content_for :head do %>
<%= auto_discovery_link_tag(:rss, { action: :category_feed }, title: t('rss_topics_in_category', category: @category.name)) %>
<%= auto_discovery_link_tag(:rss, { action: :category_feed }, rel: 'alternate nofollow', title: t('rss_topics_in_category', category: @category.name)) %>
<%= raw crawlable_meta_data(title: @category.name, description: @category.description, image: @category.uploaded_logo&.url.presence) %>
<% end %>
<% elsif @tag_id %>

2
app/views/topics/show.html.erb
View File

@ -131,7 +131,7 @@
<% end %>
<% content_for :head do %>
<%= auto_discovery_link_tag(@topic_view, {action: :feed, slug: @topic_view.topic.slug, topic_id: @topic_view.topic.id}, title: t('rss_posts_in_topic', topic: @topic_view.title), type: 'application/rss+xml') %>
<%= auto_discovery_link_tag(@topic_view, {action: :feed, slug: @topic_view.topic.slug, topic_id: @topic_view.topic.id}, rel: 'alternate nofollow', title: t('rss_posts_in_topic', topic: @topic_view.title), type: 'application/rss+xml') %>
<%= raw crawlable_meta_data(title: @topic_view.title, description: @topic_view.summary(strip_images: true), image: @topic_view.image_url, read_time: @topic_view.read_time, like_count: @topic_view.like_count, ignore_canonical: true, published_time: @topic_view.published_time) %>
<% if @topic_view.prev_page || @topic_view.next_page %>

18
spec/views/list/list.erb_spec.rb Normal file
View File

@ -0,0 +1,18 @@
# frozen_string_literal: true
require "rails_helper"
describe "list/list.erb" do
fab!(:category) { Fabricate(:category) }
it "add nofollow to RSS alternate link for category" do
view.stubs(:include_crawler_content?).returns(false)
view.stubs(:url_for).returns('https://www.example.com/test.rss')
view.instance_variable_set("@rss", false)
view.instance_variable_set("@category", category)
render template: 'list/list', formats: []
expect(view.content_for(:head)).to match(/<link rel="alternate nofollow" type="application\/rss\+xml" title="[^"]+" href="https:\/\/www.example.com\/test\.rss" \/>/)
end
end

23
spec/views/topics/show.html.erb_spec.rb Normal file
View File

@ -0,0 +1,23 @@
# frozen_string_literal: true
require "rails_helper"
require "ostruct"
describe "topics/show.html.erb" do
fab!(:topic) { Fabricate(:topic) }
it "add nofollow to RSS alternate link for topic" do
topic_view = OpenStruct.new(
topic: topic,
posts: []
)
topic_view.stubs(:summary).returns('')
view.stubs(:crawler_layout?).returns(false)
view.stubs(:url_for).returns('https://www.example.com/test.rss')
view.instance_variable_set("@topic_view", topic_view)
render template: 'topics/show', formats: [:html]
expect(view.content_for(:head)).to match(/<link rel="alternate nofollow" type="application\/rss\+xml" title="[^"]+" href="https:\/\/www.example.com\/test\.rss" \/>/)
end
end