IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FEATURE: Staff can receive pending user reminders more frequently. (#13422)

Browse Source 
* FEATURE: Staff can receive pending user reminders more frequently.

We now express the "pending_users_reminder_delay"  in minutes instead of hours so staff can have finer control over the delay.

We need to keep in mind that the reminders could still take up to 20 minutes, even when using a lower value. We send them from a scheduled job.

* Migrate to a new site setting for the reminders delay
This commit is contained in:
Roman Rizzi
2021-06-24 10:02:56 -03:00
committed by GitHub
parent 20070f5089
commit 2c918a3161
5 changed files with 39 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
spec/jobs/pending_users_reminder_spec.rb
View File

@@ -21,29 +21,30 @@ describe Jobs::PendingUsersReminder do
Group.refresh_automatic_group!(:moderators)
end
it "sends a message if user was created more than pending_users_reminder_delay hours ago" do
SiteSetting.pending_users_reminder_delay = 8
Fabricate(:user, created_at: 9.hours.ago)
it "sends a message if user was created more than pending_users_reminder_delay minutes ago" do
SiteSetting.pending_users_reminder_delay_minutes = 8
Fabricate(:user, created_at: 9.minutes.ago)
PostCreator.expects(:create).once
Jobs::PendingUsersReminder.new.execute({})
end
it "doesn't send a message if user was created less than pending_users_reminder_delay hours ago" do
SiteSetting.pending_users_reminder_delay = 8
Fabricate(:user, created_at: 2.hours.ago)
it "doesn't send a message if user was created less than pending_users_reminder_delay minutes ago" do
SiteSetting.pending_users_reminder_delay_minutes = 8
Fabricate(:user, created_at: 2.minutes.ago)
PostCreator.expects(:create).never
Jobs::PendingUsersReminder.new.execute({})
end
it "doesn't send a message if pending_users_reminder_delay is -1" do
SiteSetting.pending_users_reminder_delay = -1
SiteSetting.pending_users_reminder_delay_minutes = -1
Fabricate(:user, created_at: 24.hours.ago)
PostCreator.expects(:create).never
Jobs::PendingUsersReminder.new.execute({})
end
it "sets the correct pending user count in the notification" do
SiteSetting.pending_users_reminder_delay = 8
Fabricate(:user, created_at: 9.hours.ago)
SiteSetting.pending_users_reminder_delay_minutes = 8
Fabricate(:user, created_at: 9.minutes.ago)
PostCreator.expects(:create).with(Discourse.system_user, has_entries(title: '1 user waiting for approval'))
Jobs::PendingUsersReminder.new.execute({})
end