IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: restore docked body document from glimmer site header (#27003)

Browse Source
This commit is contained in:
Kelv 2024-05-14 00:12:38 +08:00 committed by GitHub
parent 48580de30e
commit 2df4f38a97
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/components/glimmer-site-header.gjs
View File

@ -243,7 +243,7 @@ export default class GlimmerSiteHeader extends Component {
@bind
dockCheck() {
if (this._docAt === null) {
if (this._docAt === undefined || this._docAt === null) {
if (!this.headerElement) {
return;
}

12
spec/system/header_spec.rb
View File

@ -89,6 +89,18 @@ RSpec.describe "Glimmer Header", type: :system do
expect(header.get_computed_style_value(".d-header", "--header-offset")).to eq("60px")
end
it "body document is permanently docked regardless of scroll positioning" do
Fabricate.times(20, :topic)
sign_in(current_user)
visit "/"
expect(page).to have_selector("body.docked")
page.execute_script("window.scrollBy(0, 1000)")
expect(page).to have_selector("body.docked")
page.execute_script("window.scrollTo(0, 0)")
expect(page).to have_selector("body.docked")
end
it "moves focus between tabs using arrow keys" do
sign_in(current_user)
visit "/"