IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Remove svg icons from webmanifest shortcuts (#15765)

Browse Source 
* FIX: Remove svg icons from webmanifest shortcuts

While SVGs are valid in the webmanifest, Chromium has not implemented
support for it in this specific manifest member.

Revert when https://bugs.chromium.org/p/chromium/issues/detail?id=1091612
lands.

* fix test
This commit is contained in:
Rafael dos Santos Silva 2022-02-01 15:26:58 -03:00 committed by GitHub
parent 7ee708913a
commit 2e2fee9da3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
app/controllers/metadata_controller.rb
View File

@ -65,49 +65,21 @@ class MetadataController < ApplicationController
name: I18n.t('js.topic.create_long'), name: I18n.t('js.topic.create_long'),
short_name: I18n.t('js.topic.create'), short_name: I18n.t('js.topic.create'),
url: "#{Discourse.base_path}/new-topic", url: "#{Discourse.base_path}/new-topic",
icons: [
{
src: "#{icon_url_base}/plus.svg",
sizes: "131x150",
type: "image/svg"
}
]
}, },
{ {
name: I18n.t('js.user.messages.inbox'), name: I18n.t('js.user.messages.inbox'),
short_name: I18n.t('js.user.messages.inbox'), short_name: I18n.t('js.user.messages.inbox'),
url: "#{Discourse.base_path}/my/messages", url: "#{Discourse.base_path}/my/messages",
icons: [
{
src: "#{icon_url_base}/envelope.svg",
sizes: "150x150",
type: "image/svg"
}
]
}, },
{ {
name: I18n.t('js.user.bookmarks'), name: I18n.t('js.user.bookmarks'),
short_name: I18n.t('js.user.bookmarks'), short_name: I18n.t('js.user.bookmarks'),
url: "#{Discourse.base_path}/my/activity/bookmarks", url: "#{Discourse.base_path}/my/activity/bookmarks",
icons: [
{
src: "#{icon_url_base}/bookmark.svg",
sizes: "113x150",
type: "image/svg"
}
]
}, },
{ {
name: I18n.t('js.filters.top.title'), name: I18n.t('js.filters.top.title'),
short_name: I18n.t('js.filters.top.title'), short_name: I18n.t('js.filters.top.title'),
url: "#{Discourse.base_path}/top", url: "#{Discourse.base_path}/top",
icons: [
{
src: "#{icon_url_base}/signal.svg",
sizes: "188x150",
type: "image/svg"
}
]
} }
] ]
} }

2
spec/requests/metadata_controller_spec.rb
View File

@ -94,7 +94,7 @@ RSpec.describe MetadataController do
expect(response.status).to eq(200) expect(response.status).to eq(200)
manifest = JSON.parse(response.body) manifest = JSON.parse(response.body)
expect(manifest["shortcuts"].size).to be > 0 expect(manifest["shortcuts"].size).to be > 0
expect { URI.parse(manifest["shortcuts"][0]["icons"][0]["src"]) }.not_to raise_error expect { URI.parse(manifest["shortcuts"][0]["url"]) }.not_to raise_error
end end
end end