IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Fix FakeLogger spec issues (#12397)

Browse Source 
* DEV: Add `#level` and `#level=` to `FakeLogger`

* DEV: Fix a leaky test
This commit is contained in:
Jarek Radosz
2021-03-15 05:36:10 +01:00
committed by GitHub
parent 5c84f702b0
commit 303d2227cc
2 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
spec/models/theme_spec.rb
View File

@@ -657,7 +657,10 @@ HTML
end end
it 'warns when the theme has modified the setting type but data cannot be converted' do it 'warns when the theme has modified the setting type but data cannot be converted' do
begin
@orig_logger = Rails.logger
Rails.logger = FakeLogger.new Rails.logger = FakeLogger.new
theme.set_field(target: :settings, name: :yaml, value: "valid_json_schema_setting:\n default: \"\"\n type: \"list\"") theme.set_field(target: :settings, name: :yaml, value: "valid_json_schema_setting:\n default: \"\"\n type: \"list\"")
theme.save! theme.save!
@@ -671,6 +674,9 @@ HTML
theme.convert_settings theme.convert_settings
expect(setting.value).to eq("red,globe") expect(setting.value).to eq("red,globe")
expect(Rails.logger.warnings[0]).to include("Theme setting type has changed but cannot be converted.") expect(Rails.logger.warnings[0]).to include("Theme setting type has changed but cannot be converted.")
ensure
Rails.logger = @orig_logger
end
end end
end end

1
spec/support/fake_logger.rb
View File

@@ -2,6 +2,7 @@
class FakeLogger class FakeLogger
attr_reader :warnings, :errors, :infos, :fatals attr_reader :warnings, :errors, :infos, :fatals
attr_accessor :level
def initialize def initialize
@warnings = [] @warnings = []