DEV: enable frozen string literal on all files

This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging

app/serializers/about_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AboutSerializer < ApplicationSerializer
 
   class UserAboutSerializer < BasicUserSerializer

app/serializers/admin_badge_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminBadgeSerializer < BadgeSerializer
   attributes :query, :trigger, :target_posts, :auto_revoke, :show_posts
 

app/serializers/admin_badges_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminBadgesSerializer < ApplicationSerializer
   attributes :protected_system_fields, :triggers
   has_many :badges, serializer: AdminBadgeSerializer

app/serializers/admin_detailed_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminDetailedUserSerializer < AdminUserSerializer
 
   attributes :moderator,

app/serializers/admin_email_template_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminEmailTemplateSerializer < ApplicationSerializer
   attributes :id, :title, :subject, :body, :can_revert?
 

app/serializers/admin_plugin_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminPluginSerializer < ApplicationSerializer
   attributes :id,
              :name,

app/serializers/admin_user_action_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'post_item_excerpt'
 
 class AdminUserActionSerializer < ApplicationSerializer

app/serializers/admin_user_list_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminUserListSerializer < BasicUserSerializer
 
   attributes :email,

app/serializers/admin_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'admin_user_list_serializer'
 
 class AdminUserSerializer < AdminUserListSerializer

app/serializers/admin_web_hook_event_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminWebHookEventSerializer < ApplicationSerializer
   attributes :id,
              :web_hook_id,

app/serializers/admin_web_hook_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AdminWebHookSerializer < ApplicationSerializer
   attributes :id,
              :payload_url,

app/serializers/api_key_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ApiKeySerializer < ApplicationSerializer
 
   attributes :id,

app/serializers/application_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'distributed_cache'
 
 class ApplicationSerializer < ActiveModel::Serializer

app/serializers/archetype_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ArchetypeSerializer < ApplicationSerializer
 
   attributes :id, :name, :options

app/serializers/auth_provider_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AuthProviderSerializer < ApplicationSerializer
 
   attributes :name, :custom_url, :pretty_name_override, :title_override, :message_override,

app/serializers/backup_file_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BackupFileSerializer < ApplicationSerializer
   attributes :filename,
              :size,

app/serializers/badge_grouping_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BadgeGroupingSerializer < ApplicationSerializer
   attributes :id, :name, :description, :position, :system
 

app/serializers/badge_index_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BadgeIndexSerializer < BadgeSerializer
   attributes :has_badge
   has_one :badge_grouping

app/serializers/badge_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BadgeSerializer < ApplicationSerializer
   attributes :id, :name, :description, :grant_count, :allow_title,
              :multiple_grant, :icon, :image, :listable, :enabled, :badge_grouping_id,

app/serializers/badge_type_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BadgeTypeSerializer < ApplicationSerializer
   attributes :id, :name, :sort_order
 

app/serializers/basic_category_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicCategorySerializer < ApplicationSerializer
 
   attributes :id,

app/serializers/basic_group_history_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicGroupHistorySerializer < ApplicationSerializer
   attributes :action,
              :subject,

app/serializers/basic_group_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicGroupSerializer < ApplicationSerializer
   attributes :id,
              :automatic,

app/serializers/basic_group_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicGroupUserSerializer < ApplicationSerializer
   attributes :group_id, :user_id, :notification_level, :owner
 

app/serializers/basic_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The most basic attributes of a topic that we need to create a link for it.
 class BasicPostSerializer < ApplicationSerializer
   attributes :id,

app/serializers/basic_topic_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The most basic attributes of a topic that we need to create a link for it.
 class BasicTopicSerializer < ApplicationSerializer
   attributes :id, :title, :fancy_title, :slug, :posts_count

app/serializers/basic_user_badge_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicUserBadgeSerializer < ApplicationSerializer
   attributes :id, :granted_at, :count, :grouping_position
 

app/serializers/basic_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class BasicUserSerializer < ApplicationSerializer
   attributes :id, :username, :name, :avatar_template
 

app/serializers/category_and_topic_lists_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CategoryAndTopicListsSerializer < ApplicationSerializer
   has_one :category_list, serializer: CategoryListSerializer, embed: :objects
   has_one :topic_list, serializer: TopicListSerializer, embed: :objects

app/serializers/category_detailed_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CategoryDetailedSerializer < BasicCategorySerializer
 
   attributes :topic_count,

app/serializers/category_list_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CategoryListSerializer < ApplicationSerializer
 
   attributes :can_create_category,

app/serializers/category_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CategorySerializer < BasicCategorySerializer
 
   attributes :read_restricted,

app/serializers/category_upload_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CategoryUploadSerializer < ApplicationSerializer
   attributes :id, :url, :width, :height
 end

app/serializers/color_scheme_color_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ColorSchemeColorSerializer < ApplicationSerializer
   attributes :name, :hex, :default_hex
 

app/serializers/color_scheme_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ColorSchemeSerializer < ApplicationSerializer
   attributes :id, :name, :is_base, :base_scheme_id, :theme_id, :theme_name
   has_many :colors, serializer: ColorSchemeColorSerializer, embed: :objects

app/serializers/concerns/email_logs_mixin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module EmailLogsMixin
   def self.included(klass)
     klass.attributes :id,

app/serializers/concerns/topic_tags_mixin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module TopicTagsMixin
   def self.included(klass)
     klass.attributes :tags

app/serializers/concerns/user_auth_tokens_mixin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'browser_detection'
 require_dependency 'discourse_ip_info'
 

app/serializers/concerns/user_primary_group_mixin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module UserPrimaryGroupMixin
 
   def self.included(klass)

app/serializers/current_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'new_post_manager'
 
 class CurrentUserSerializer < BasicUserSerializer

app/serializers/detailed_user_badge_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DetailedUserBadgeSerializer < BasicUserBadgeSerializer
   has_one :granted_by, serializer: UserBadgeSerializer::UserSerializer
 

app/serializers/directory_item_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DirectoryItemSerializer < ApplicationSerializer
 
   class UserSerializer < UserNameSerializer

app/serializers/directory_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DirectorySerializer < ApplicationSerializer
   attributes :id
   has_many :directory_items, serializer: DirectoryItemSerializer, embed: :objects

app/serializers/discourse_version_check_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class DiscourseVersionCheckSerializer < ApplicationSerializer
   attributes :latest_version,
              :critical_updates,

app/serializers/draft_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'post_item_excerpt'
 
 class DraftSerializer < ApplicationSerializer

app/serializers/email_log_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EmailLogSerializer < ApplicationSerializer
   include EmailLogsMixin
 

app/serializers/embeddable_host_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EmbeddableHostSerializer < ApplicationSerializer
 
   TO_SERIALIZE = [:id, :host, :path_whitelist, :class_name, :category_id]

app/serializers/embedding_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EmbeddingSerializer < ApplicationSerializer
   attributes :id, :fields, :base_url
   attributes *Embedding.settings

app/serializers/emoji_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class EmojiSerializer < ApplicationSerializer
   attributes :name, :url
 end

app/serializers/flagged_topic_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class FlaggedTopicSerializer < ActiveModel::Serializer
   attributes :id,
              :title,

app/serializers/flagged_topic_summary_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class FlaggedTopicSummarySerializer < ActiveModel::Serializer
 
   attributes(

app/serializers/flagged_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class FlaggedUserSerializer < BasicUserSerializer
   attributes :can_delete_all_posts,
              :can_be_deleted,

app/serializers/gap_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GapSerializer < ApplicationSerializer
   attributes :before, :after
 

app/serializers/group_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'post_item_excerpt'
 
 class GroupPostSerializer < ApplicationSerializer

app/serializers/group_post_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupPostUserSerializer < BasicUserSerializer
   attributes :title, :name
 end

app/serializers/group_requester_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupRequesterSerializer < BasicUserSerializer
   attributes :reason, :requested_at
 end

app/serializers/group_show_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupShowSerializer < BasicGroupSerializer
   attributes :is_group_user, :is_group_owner, :is_group_owner_display, :mentionable, :messageable
 

app/serializers/group_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupUserSerializer < BasicUserSerializer
   include UserPrimaryGroupMixin
 

app/serializers/grouped_screened_url_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupedScreenedUrlSerializer < ApplicationSerializer
   attributes :domain,
              :action,

app/serializers/grouped_search_result_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class GroupedSearchResultSerializer < ApplicationSerializer
   has_many :posts, serializer: SearchPostSerializer
   has_many :users, serializer: SearchResultUserSerializer

app/serializers/hidden_profile_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class HiddenProfileSerializer < BasicUserSerializer
   attributes(
     :profile_hidden?,

app/serializers/incoming_email_details_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IncomingEmailDetailsSerializer < ApplicationSerializer
 
   attributes :error,

app/serializers/incoming_email_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class IncomingEmailSerializer < ApplicationSerializer
 
   attributes :id,

app/serializers/invite_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class InviteSerializer < ApplicationSerializer
 
   attributes :email, :created_at, :redeemed_at, :expired, :user

app/serializers/invited_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class InvitedUserSerializer < BasicUserSerializer
 
   attributes :topics_entered,

app/serializers/listable_topic_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'pinned_check'
 
 class ListableTopicSerializer < BasicTopicSerializer

app/serializers/new_post_result_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'application_serializer'
 
 class NewPostResultSerializer < ApplicationSerializer

app/serializers/notification_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class NotificationSerializer < ApplicationSerializer
 
   attributes :id,

app/serializers/penalty_counts_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PenaltyCountsSerializer < ApplicationSerializer
   attributes :silenced, :suspended, :total
 

app/serializers/permalink_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PermalinkSerializer < ApplicationSerializer
   attributes :id, :url, :topic_id, :topic_title, :topic_url,
              :post_id, :post_url, :post_number, :post_topic_title,

app/serializers/post_action_type_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'configurable_urls'
 
 class PostActionTypeSerializer < ApplicationSerializer

app/serializers/post_action_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostActionUserSerializer < BasicUserSerializer
   attributes :post_url,
              :username_lower

app/serializers/post_item_excerpt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module PostItemExcerpt
 
   def self.included(base)

app/serializers/post_revision_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostRevisionSerializer < ApplicationSerializer
 
   attributes :created_at,

app/serializers/post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PostSerializer < BasicPostSerializer
 
   # To pass in additional information we might need

app/serializers/post_stream_serializer_mixin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'gap_serializer'
 require_dependency 'post_serializer'
 require_dependency 'timeline_lookup'

app/serializers/post_wordpress_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # The most basic attributes of a topic that we need to create a link for it.
 class PostWordpressSerializer < BasicPostSerializer
   attributes :post_number

app/serializers/primary_group_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class PrimaryGroupSerializer < ApplicationSerializer
   attributes :id, :name, :flair_url, :flair_bg_color, :flair_color
 end

app/serializers/queued_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Deprecated, should be removed once users have sufficient opportunity to do so
 class QueuedPostSerializer < ApplicationSerializer
 

app/serializers/reviewable_action_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableActionSerializer < ApplicationSerializer
   attributes :id, :icon, :label, :confirm_message, :description, :client_action
 

app/serializers/reviewable_bundled_action_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableBundledActionSerializer < ApplicationSerializer
   attributes :id, :icon, :label
   has_many :actions, serializer: ReviewableActionSerializer, root: 'actions'

app/serializers/reviewable_conversation_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableConversationPostSerializer < ApplicationSerializer
   attributes :id, :excerpt
   has_one :user, serializer: BasicUserSerializer, root: 'users'

app/serializers/reviewable_conversation_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableConversationSerializer < ApplicationSerializer
   attributes :id, :permalink, :has_more
   has_many :conversation_posts, serializer: ReviewableConversationPostSerializer

app/serializers/reviewable_editable_field_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableEditableFieldSerializer < ApplicationSerializer
   attributes :id, :type
 end

app/serializers/reviewable_flagged_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableFlaggedPostSerializer < ReviewableSerializer
   target_attributes :cooked, :raw, :reply_count
   attributes :blank_post, :post_updated_at, :post_version

app/serializers/reviewable_history_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableHistorySerializer < ApplicationSerializer
 
   attributes :id, :reviewable_history_type, :status, :created_at

app/serializers/reviewable_perform_result_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewablePerformResultSerializer < ApplicationSerializer
 
   attributes(

app/serializers/reviewable_queued_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableQueuedPostSerializer < ReviewableSerializer
 
   payload_attributes(

app/serializers/reviewable_score_bonus_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableScoreBonusSerializer < ApplicationSerializer
   attributes :id, :name, :score_bonus
 

app/serializers/reviewable_score_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'reviewable_score_type_serializer'
 
 class ReviewableScoreSerializer < ApplicationSerializer

app/serializers/reviewable_score_type_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableScoreTypeSerializer < ApplicationSerializer
   attributes :id, :title, :score_bonus, :icon
 

app/serializers/reviewable_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'reviewable_action_serializer'
 require_dependency 'reviewable_editable_field_serializer'
 

app/serializers/reviewable_settings_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableSettingsSerializer < ApplicationSerializer
   attributes :id
 

app/serializers/reviewable_topic_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableTopicSerializer < ApplicationSerializer
   attributes(
     :id,

app/serializers/reviewable_user_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ReviewableUserSerializer < ReviewableSerializer
 
   attributes :link_admin, :user_fields

app/serializers/screened_email_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ScreenedEmailSerializer < ApplicationSerializer
   attributes :email,
              :action,

app/serializers/screened_ip_address_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ScreenedIpAddressSerializer < ApplicationSerializer
   attributes :id,
              :ip_address,

app/serializers/screened_url_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class ScreenedUrlSerializer < ApplicationSerializer
   attributes :url,
              :domain,

app/serializers/search_logs_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SearchLogsSerializer < ApplicationSerializer
   attributes :term,
              :searches,

app/serializers/search_post_serializer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SearchPostSerializer < BasicPostSerializer
   has_one :topic, serializer: SearchTopicListItemSerializer