DEV: enable frozen string literal on all files

This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging

config/boot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV['DISCOURSE_DUMP_HEAP'] == "1"
   require 'objspace'
   ObjectSpace.trace_object_allocations_start

config/cloud/cloud66/files/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Discourse::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/environment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Load the rails application
 require File.expand_path('../application', __FILE__)
 

config/environments/development.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Discourse::Application.configure do
 
   # Settings specified here will take precedence over those in config/application.rb

config/environments/production.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Discourse::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/environments/profile.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Discourse::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/environments/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Discourse::Application.configure do
   # Settings specified here will take precedence over those in config/application.rb
 

config/initializers/000-mini_sql.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 require 'mini_sql_multisite_connection'
 ::DB = MiniSqlMultisiteConnection.instance

config/initializers/000-post_migration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 unless Discourse.skip_post_deployment_migrations?
   Rails.application.config.paths['db/migrate'] << Rails.root.join(
     Discourse::DB_POST_MIGRATE_PATH

config/initializers/001-redis.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if Rails.env.development? && ENV['DISCOURSE_FLUSH_REDIS']
   puts "Flushing redis (development mode)"
   $redis.flushall

config/initializers/002-freedom_patches.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Dir["#{Rails.root}/lib/freedom_patches/*.rb"].each do |f|
   require(f)
 end

config/initializers/003-sql_builder.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require 'sql_builder'

config/initializers/004-message_bus.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 MessageBus.site_id_lookup do |env = nil|
   if env
     setup_message_bus_env(env)

config/initializers/005-site_settings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # load up git version into memory
 # this way if it changes underneath we still have
 # the original version

config/initializers/006-ensure_login_hint.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Some sanity checking so we don't count on an unindexed column on boot
 begin
   if ActiveRecord::Base.connection.table_exists?(:users) &&

config/initializers/006-mini_profiler.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # If Mini Profiler is included via gem
 if Rails.configuration.respond_to?(:load_mini_profiler) && Rails.configuration.load_mini_profiler
   require 'rack-mini-profiler'

config/initializers/009-omniauth.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "openssl"
 require "openid_redis_store"
 

config/initializers/010-discourse_iife.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'discourse_iife'
 
 Rails.application.config.assets.configure do |env|

config/initializers/011-rack-protection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rack/protection'
 
 Rails.configuration.middleware.use Rack::Protection::FrameOptions

config/initializers/012-web_hook_events.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 %i(
   topic_recovered
 ).each do |event|

config/initializers/013-excon_defaults.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 Excon::DEFAULTS[:omit_default_port] = true

config/initializers/014-track-setting-changes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency "site_icon_manager"
 
 DiscourseEvent.on(:site_setting_changed) do |name, old_value, new_value|

config/initializers/050-force_https.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # tiny middleware to force https if needed
 class Discourse::ForceHttpsMiddleware
 

config/initializers/099-anon-cache.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "middleware/anonymous_cache"
 
 enabled =

config/initializers/099-defer.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require_dependency 'scheduler/defer'

config/initializers/099-drain_pool.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # pg performs inconsistently with large amounts of connections
 Discourse.start_connection_reaper

config/initializers/100-i18n.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # order: after 02-freedom_patches.rb
 
 require 'i18n/backend/discourse_i18n'

config/initializers/100-logster.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if Rails.env.development? && RUBY_VERSION.match?(/^2\.5\.[23]/)
   STDERR.puts "WARNING: Discourse development environment runs slower on Ruby 2.5.3 or below"
   STDERR.puts "We recommend you upgrade to Ruby 2.6.1 for the optimal development performance"

config/initializers/100-oj.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 # Not sure why it's not using this by default!
 MultiJson.engine = :oj

config/initializers/100-onebox_options.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'twitter_api'
 
 Onebox.options = {

config/initializers/100-push-notifications.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'webpush'
 
 if SiteSetting.vapid_public_key.blank? || SiteSetting.vapid_private_key.blank? || SiteSetting.vapid_public_key_bytes.blank?

config/initializers/100-quiet_logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Rails.application.config.assets.configure do |env|
   env.logger = Logger.new('/dev/null')
 end

config/initializers/100-secret_token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Not fussed setting secret_token anymore, that is only required for
 # backwards support of "seamless" upgrade from Rails 3.
 # Discourse has shipped Rails 3 for a very long time.

config/initializers/100-session_store.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 #
 require_dependency 'discourse_cookie_store'

config/initializers/100-sidekiq.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "sidekiq/pausable"
 
 Sidekiq.configure_client do |config|

config/initializers/100-silence_logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class SilenceLogger < Rails::Rack::Logger
   PATH_INFO = 'PATH_INFO'.freeze
   HTTP_X_SILENCE_LOGGER = 'HTTP_X_SILENCE_LOGGER'.freeze

config/initializers/100-strong_parameters.rb

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 ActiveRecord::Base.public_send(:include, ActiveModel::ForbiddenAttributesProtection)

config/initializers/100-verify_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Check that the app is configured correctly. Raise some helpful errors if something is wrong.
 
 if defined?(Rails::Server) && Rails.env.production? # Only run these checks when starting up a production server

config/initializers/100-watch_for_restart.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # this is a trivial graceful restart on touch of tmp/restart.
 #
 # It simply drains all the requests (waits up to 4 seconds) and issues a HUP

config/initializers/100-wrap_parameters.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 #
 # This file contains settings for ActionController::ParamsWrapper which

config/initializers/101-lograge.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if (Rails.env.production? && SiteSetting.logging_provider == 'lograge') || ENV["ENABLE_LOGRAGE"]
   require 'lograge'
 

config/initializers/200-message_bus_request_tracker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # we want MesageBus in the absolute front
 # this is important cause the vast majority of web requests go to it
 # this allows us to avoid full middleware crawls each time

config/locales/plurals.rb

@@ -1,4 +1,6 @@
 # encoding: utf-8
+# frozen_string_literal: true
+
 # source: https://github.com/svenfuchs/i18n/blob/master/test/test_data/locales/plurals.rb
 
 {

config/puma.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ENV['RAILS_ENV'] == 'production'
 
   # First, you need to change these below to your situation.

config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "sidekiq/web"
 require "mini_scheduler/web"
 require_dependency "admin_constraint"

config/spring.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # spring speeds up your dev environment, similar to zeus but build in Ruby
 #
 # gem install spring

config/unicorn.conf.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # See http://unicorn.bogomips.org/Unicorn/Configurator.html
 
 if ENV["LOGSTASH_UNICORN_URI"]