DEV: enable frozen string literal on all files

This reduces chances of errors where consumers of strings mutate inputs
and reduces memory usage of the app.

Test suite passes now, but there may be some stuff left, so we will run
a few sites on a branch prior to merging

script/bench.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "socket"
 require "csv"
 require "yaml"

script/benchmarks/markdown/bench.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'benchmark/ips'
 require File.expand_path('../../../../config/environment', __FILE__)
 

script/benchmarks/middleware/test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'memory_profiler'
 require 'benchmark/ips'
 

script/benchmarks/site_setting/bench.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'benchmark/ips'
 require File.expand_path('../../../../config/environment', __FILE__)
 

script/benchmarks/site_setting/profile.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'ruby-prof'
 
 def profile(&blk)

script/boot_mem.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # simple script to measure memory at boot
 
 if ENV['RAILS_ENV'] != "production"

script/bulk_import/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ARGV.include?('bbcode-to-md')
   # Replace (most) bbcode with markdown before creating posts.
   # This will dramatically clean up the final posts in Discourse.

script/bulk_import/discourse_merger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "base"
 
 class BulkImport::DiscourseMerger < BulkImport::Base

script/bulk_import/phpbb_postgresql.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "base"
 require "pg"
 require "htmlentities"

script/bulk_import/vanilla.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "base"
 require "mysql2"
 require "rake"

script/bulk_import/vbulletin.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative "base"
 require "set"
 require "mysql2"

script/check_forking.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path("../../config/environment", __FILE__)
 
 def pretty

script/compile_hbs.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 ctx = MiniRacer::Context.new(timeout: 15000)
 ctx.eval("var self = this; #{File.read("#{Rails.root}/vendor/assets/javascripts/babel.js")}")
 ctx.eval(File.read(Ember::Source.bundled_path_for('ember-template-compiler.js')))

script/demon_test/child

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 $parent_pid = ARGV[0].to_i
 

script/demon_test/parent.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path("../../../config/environment", __FILE__)
 
 puts "Parent is now loaded"

script/diff_heaps.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # to be used to compare ruby heaps generated in 2.1
 # can isolate memory leaks
 #

script/discourse

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "thor"
 

script/docker_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # This script is run in the discourse_test docker image
 # Available environment variables:
 # => NO_UPDATE        disables updating the source code within the discourse_test docker image

script/downsize_uploads.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path("../../config/environment", __FILE__)
 
 # no less than 1 megapixel

script/import_scripts/answerbase.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'csv'
 require 'reverse_markdown'
 require_relative 'base'

script/import_scripts/askbot.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require 'pg'
 

script/import_scripts/base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ARGV.include?('bbcode-to-md')
   # Replace (most) bbcode with markdown before creating posts.
   # This will dramatically clean up the final posts in Discourse.

script/import_scripts/base/csv_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts
   module CsvHelper
     class RowResolver

script/import_scripts/base/generic_database.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sqlite3'
 
 module ImportScripts

script/import_scripts/base/lookup_container.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts
   class LookupContainer
     def initialize

script/import_scripts/base/uploader.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'url_helper'
 require_dependency 'file_helper'
 

script/import_scripts/bbpress.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mysql2'
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/bespoke_1.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # bespoke importer for a customer, feel free to borrow ideas
 
 require 'csv'

script/import_scripts/discuz_x.rb

@@ -1,4 +1,6 @@
 # encoding: utf-8
+# frozen_string_literal: true
+
 #
 # Author: Erick Guan <fantasticfears@gmail.com>
 #

script/import_scripts/disqus.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'nokogiri'
 require 'optparse'
 require File.expand_path(File.dirname(__FILE__) + "/base")

script/import_scripts/drupal-6.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/drupal.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/drupal_json.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 
 # Edit the constants and initialize method for your import data.

script/import_scripts/drupal_qa.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require File.expand_path(File.dirname(__FILE__) + "/drupal.rb")

script/import_scripts/fluxbb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")

script/import_scripts/friendsmegplus.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 
 require 'csv'

script/import_scripts/getsatisfaction.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # getsatisfaction importer
 #
 # pre-req: You will either get an Excel or a bunch of CSV files. Be sure to rename them all so that

script/import_scripts/google_groups.rb

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require "bundler/inline"
 

script/import_scripts/ipboard.rb

@@ -1,4 +1,6 @@
 # coding: utf-8
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require 'htmlentities'

script/import_scripts/ipboard3.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require "reverse_markdown"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")

script/import_scripts/jive.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Jive importer
 require 'nokogiri'
 require 'csv'

script/import_scripts/jive_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "nokogiri"
 require "htmlentities"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")

script/import_scripts/json_generic.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "csv"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/kunena.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/kunena3.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/lithium.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Notes:
 #
 # Written by Sam

script/import_scripts/mbox.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 if ARGV.length != 1 || !File.exists?(ARGV[0])
   STDERR.puts '', 'Usage of mbox importer:', 'bundle exec ruby mbox.rb <path/to/settings.yml>'
   STDERR.puts '', "Use the settings file from #{File.expand_path('mbox/settings.yml', File.dirname(__FILE__))} as an example."

script/import_scripts/mbox/importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../base'
 require_relative 'support/database'
 require_relative 'support/indexer'

script/import_scripts/mbox/support/database.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'sqlite3'
 
 module ImportScripts::Mbox

script/import_scripts/mbox/support/indexer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'database'
 require 'json'
 require 'yaml'

script/import_scripts/mbox/support/settings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 
 module ImportScripts::Mbox

script/import_scripts/modx.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mysql2'
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require 'htmlentities'

script/import_scripts/muut.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "csv"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/mybb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/mylittleforum.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require 'htmlentities'

script/import_scripts/nabble.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require 'pg'
 require_relative 'base/uploader'

script/import_scripts/ning.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 
 # Edit the constants and initialize method for your import data.

script/import_scripts/nodebb/nodebb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../base.rb'
 require_relative './redis'
 

script/import_scripts/nodebb/redis.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'redis'
 
 module NodeBB

script/import_scripts/phorum.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")

script/import_scripts/phpbb3.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Importer for phpBB 3.0 and 3.1
 # Documentation: https://meta.discourse.org/t/importing-from-phpbb3/30810
 

script/import_scripts/phpbb3/database/database.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mysql2'
 
 module ImportScripts::PhpBB3

script/import_scripts/phpbb3/database/database_3_0.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'database_base'
 require_relative '../support/constants'
 

script/import_scripts/phpbb3/database/database_3_1.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'database_3_0'
 require_relative '../support/constants'
 

script/import_scripts/phpbb3/database/database_base.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class DatabaseBase
     # @param database_client [Mysql2::Client]

script/import_scripts/phpbb3/importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../base'
 require_relative 'support/settings'
 require_relative 'database/database'

script/import_scripts/phpbb3/importers/attachment_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class AttachmentImporter
     # @param database [ImportScripts::PhpBB3::Database_3_0 | ImportScripts::PhpBB3::Database_3_1]

script/import_scripts/phpbb3/importers/avatar_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class AvatarImporter
     # @param uploader [ImportScripts::Uploader]

script/import_scripts/phpbb3/importers/bookmark_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class BookmarkImporter
     def map_bookmark(row)

script/import_scripts/phpbb3/importers/category_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class CategoryImporter
     # @param lookup [ImportScripts::LookupContainer]

script/import_scripts/phpbb3/importers/importer_factory.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'attachment_importer'
 require_relative 'avatar_importer'
 require_relative 'bookmark_importer'

script/import_scripts/phpbb3/importers/message_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class MessageImporter
     # @param database [ImportScripts::PhpBB3::Database_3_0 | ImportScripts::PhpBB3::Database_3_1]

script/import_scripts/phpbb3/importers/permalink_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class PermalinkImporter
     CATEGORY_LINK_NORMALIZATION = '/(viewforum.php\?)(?:.*&)?(f=\d+).*/\1\2'

script/import_scripts/phpbb3/importers/poll_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class PollImporter
     # @param lookup [ImportScripts::LookupContainer]

script/import_scripts/phpbb3/importers/post_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class PostImporter
     # @param lookup [ImportScripts::LookupContainer]

script/import_scripts/phpbb3/importers/user_importer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../support/constants'
 
 module ImportScripts::PhpBB3

script/import_scripts/phpbb3/support/constants.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class Constants
     ACTIVE_USER = 0

script/import_scripts/phpbb3/support/settings.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 
 module ImportScripts::PhpBB3

script/import_scripts/phpbb3/support/smiley_processor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class SmileyProcessor
     # @param uploader [ImportScripts::Uploader]

script/import_scripts/phpbb3/support/text_processor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ImportScripts::PhpBB3
   class TextProcessor
     # @param lookup [ImportScripts::LookupContainer]

script/import_scripts/punbb.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")

script/import_scripts/quandora/export.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require_relative 'quandora_api'
 

script/import_scripts/quandora/import.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative './quandora_question.rb'
 require File.expand_path(File.dirname(__FILE__) + "/../base.rb")
 

script/import_scripts/quandora/quandora_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 require 'json'
 

script/import_scripts/quandora/quandora_question.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'cgi'
 require 'time'

script/import_scripts/quandora/test/test_data.rb

@@ -1,3 +1,4 @@
+  # frozen_string_literal: true
   BASES = '{
     "type" : "kbase",
     "data" : [ {

script/import_scripts/quandora/test/test_quandora_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require 'yaml'
 require_relative '../quandora_api.rb'

script/import_scripts/quandora/test/test_quandora_question.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require 'cgi'
 require 'time'

script/import_scripts/question2answer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mysql2'
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 require 'htmlentities'

script/import_scripts/sfn.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # custom importer for www.sfn.org, feel free to borrow ideas
 
 require "csv"

script/import_scripts/simplepress.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'mysql2'
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")
 

script/import_scripts/smf1.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "mysql2"
 require "htmlentities"
 require File.expand_path(File.dirname(__FILE__) + "/base.rb")

script/import_scripts/smf2.rb

@@ -1,4 +1,6 @@
 # coding: utf-8
+# frozen_string_literal: true
+
 require 'mysql2'
 require File.expand_path(File.dirname(__FILE__) + '/base.rb')
 

script/import_scripts/socialcast/create_title.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'uri'
 
 class CreateTitle

script/import_scripts/socialcast/export.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'fileutils'
 require_relative 'socialcast_api'

script/import_scripts/socialcast/import.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative './socialcast_message.rb'
 require_relative './socialcast_user.rb'
 require 'set'

script/import_scripts/socialcast/socialcast_api.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'base64'
 require 'json'
 

script/import_scripts/socialcast/socialcast_message.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'cgi'
 require 'time'

script/import_scripts/socialcast/socialcast_user.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'cgi'
 require 'time'

script/import_scripts/socialcast/test/test_create_title.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'minitest/autorun'
 require_relative '../create_title.rb'