select-kit refactoring

* better test helper
* more reliable tests
* more consistent use of data-value/data-name/title/aria-label everywhere: header and rows

plugins/discourse-details/test/javascripts/acceptance/details-button-test.js.es6

@@ -1,16 +1,24 @@
 import { acceptance } from "helpers/qunit-helpers";
+import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
 
-acceptance('Details Button', { loggedIn: true });
+acceptance('Details Button', {
+  loggedIn: true,
+  beforeEach: function() {
+    clearPopupMenuOptionsCallback();
+  }
+});
 
 function findTextarea() {
   return find(".d-editor-input")[0];
 }
 
 test('details button', (assert) => {
+  const popupMenu = selectKit('.toolbar-popup-menu-options');
+
   visit("/");
   click('#create-topic');
-  expandSelectKit('.toolbar-popup-menu-options');
-  selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
+
+  popupMenu.expand().selectRowByValue('insertDetails');
 
   andThen(() => {
     assert.equal(
@@ -28,8 +36,7 @@ test('details button', (assert) => {
     textarea.selectionEnd = textarea.value.length;
   });
 
-  expandSelectKit('.toolbar-popup-menu-options');
-  selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
+  popupMenu.expand().selectRowByValue('insertDetails');
 
   andThen(() => {
     assert.equal(
@@ -51,8 +58,7 @@ test('details button', (assert) => {
     textarea.selectionEnd = 28;
   });
 
-  expandSelectKit('.toolbar-popup-menu-options');
-  selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
+  popupMenu.expand().selectRowByValue('insertDetails');
 
   andThen(() => {
     assert.equal(
@@ -74,8 +80,7 @@ test('details button', (assert) => {
     textarea.selectionEnd = 29;
   });
 
-  expandSelectKit('.toolbar-popup-menu-options');
-  selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
+  popupMenu.expand().selectRowByValue('insertDetails');
 
   andThen(() => {
     assert.equal(
@@ -92,6 +97,7 @@ test('details button', (assert) => {
 
 test('details button surrounds all selected text in a single details block', (assert) => {
   const multilineInput = 'first line\n\nsecond line\n\nthird line';
+  const popupMenu = selectKit('.toolbar-popup-menu-options');
 
   visit("/");
   click('#create-topic');
@@ -103,8 +109,7 @@ test('details button surrounds all selected text in a single details block', (as
     textarea.selectionEnd = textarea.value.length;
   });
 
-  expandSelectKit('.toolbar-popup-menu-options');
-  selectKitSelectRow('insertDetails', { selector: '.toolbar-popup-menu-options'});
+  popupMenu.expand().selectRowByValue('insertDetails');
 
   andThen(() => {
     assert.equal(

plugins/poll/test/javascripts/acceptance/poll-builder-disabled-test.js.es6

@@ -1,12 +1,16 @@
 import { acceptance } from "helpers/qunit-helpers";
 import { displayPollBuilderButton } from "discourse/plugins/poll/helpers/display-poll-builder-button";
 import { replaceCurrentUser } from "discourse/plugins/poll/helpers/replace-current-user";
+import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
 
 acceptance("Poll Builder - polls are disabled", {
   loggedIn: true,
   settings: {
     poll_enabled: false,
     poll_minimum_trust_level_to_create: 2
+  },
+  beforeEach: function() {
+    clearPopupMenuOptionsCallback();
   }
 });
 

plugins/poll/test/javascripts/acceptance/poll-builder-enabled-test.js.es6

@@ -1,12 +1,16 @@
 import { acceptance } from "helpers/qunit-helpers";
 import { displayPollBuilderButton } from "discourse/plugins/poll/helpers/display-poll-builder-button";
 import { replaceCurrentUser } from "discourse/plugins/poll/helpers/replace-current-user";
+import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
 
 acceptance("Poll Builder - polls are enabled", {
   loggedIn: true,
   settings: {
     poll_enabled: true,
     poll_minimum_trust_level_to_create: 1
+  },
+  beforeEach: function() {
+    clearPopupMenuOptionsCallback();
   }
 });
 

plugins/poll/test/javascripts/acceptance/polls-test.js.es6

@@ -1,8 +1,12 @@
 import { acceptance } from "helpers/qunit-helpers";
+import { clearPopupMenuOptionsCallback } from "discourse/controllers/composer";
 
 acceptance("Rendering polls", {
   loggedIn: true,
-  settings: { poll_enabled: true }
+  settings: { poll_enabled: true },
+  beforeEach: function() {
+    clearPopupMenuOptionsCallback();
+  }
 });
 
 test("Single Poll", (assert) => {

plugins/poll/test/javascripts/helpers/display-poll-builder-button.js.es6

@@ -2,6 +2,5 @@ export function displayPollBuilderButton() {
   visit("/");
   click("#create-topic");
   click(".d-editor-button-bar .options");
-
-  expandSelectKit('.toolbar-popup-menu-options');
+  selectKit(".toolbar-popup-menu-options").expand();
 }