FIX: Broken GitHub folder onebox logic (#15612)

Browse Source

1. `html_doc.css('.Box.md')` always returns a truthy value (e.g. `[]`) so the second branch of the if-elsif never ran
2. `node&.css('text()')` was invalid code that would raise an error
3. Matching on h3 elements is no longer correct with the current html structure returned by GitHub

...

This commit is contained in:

Jarek Radosz

2022-01-17 18:32:07 +01:00

committed by GitHub

parent 59d78dcfcc

commit 31b27b3712

3 changed files with 2406 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

2391

spec/fixtures/onebox/githubfolder-rdoc-root.response vendored Normal file

File diff suppressed because one or more lines are too long