IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Remove logical OR assignment of constants (#29201)

Browse Source 
Constants should always be only assigned once. The logical OR assignment
of a constant is a relic of the past before we used zeitwerk for
autoloading and had bugs where a file could be loaded twice resulting in
constant redefinition warnings.
This commit is contained in:
Alan Guo Xiang Tan
2024-10-16 10:09:07 +08:00
committed by GitHub
parent f3f37c9019
commit 322a3be2db
112 changed files with 267 additions and 267 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
spec/fixtures/db/post_migrate/drop_column/20990309014014_drop_post_columns.rb vendored
View File

@@ -1,7 +1,7 @@
# frozen_string_literal: true
class DropPostColumns < ActiveRecord::Migration[5.2]
DROPPED_COLUMNS ||= { posts: %i[via_email raw_email] }
DROPPED_COLUMNS = { posts: %i[via_email raw_email] }
def up
remove_column :posts, :via_email

2
spec/fixtures/db/post_migrate/drop_table/20990309014013_drop_email_logs_table.rb vendored
View File

@@ -1,7 +1,7 @@
# frozen_string_literal: true
class DropEmailLogsTable < ActiveRecord::Migration[5.2]
DROPPED_TABLES ||= %i[email_logs]
DROPPED_TABLES = %i[email_logs]
def up
drop_table :email_logs